Skip to content

Use at least solidus_support 0.12.0#225

Merged
tvdeyen merged 1 commit intosolidusio:mainfrom
tvdeyen:raise-solidus_support
Dec 18, 2024
Merged

Use at least solidus_support 0.12.0#225
tvdeyen merged 1 commit intosolidusio:mainfrom
tvdeyen:raise-solidus_support

Conversation

@tvdeyen
Copy link
Copy Markdown
Member

@tvdeyen tvdeyen commented Dec 17, 2024

solidus_support 0.11.0 introduced flickwerk for patch loading. Somehow this messes with the zeitwerk autoloader and things acting weird (inflections broken, wrong constant module nesting, etc.)

0.12.0 reverted flickwerk.

solidus_support 0.11.0 introduced flickwerk for patch
loading. Somehow this messes with the zeitwerk autoloader
and things acting weird (inflections broken, wrong constant
module nesting, etc.)

0.12.0 reverted flickwerk.
@tvdeyen tvdeyen requested a review from a team December 17, 2024 19:45
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Dec 17, 2024

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

@mergify mergify Bot added the needs changelog label Needs a label to determine the type of change. label Dec 17, 2024
@tvdeyen tvdeyen merged commit 9dfc20a into solidusio:main Dec 18, 2024
@tvdeyen tvdeyen added enhancement Improves an existing feature. and removed needs changelog label Needs a label to determine the type of change. labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improves an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants