Merged
Conversation
elia
force-pushed
the
elia/rspec-junit-formatter
branch
from
2c044f6 to
c992d53
Compare
aldesantis
requested changes
Nov 29, 2019
elia
force-pushed
the
elia/rspec-junit-formatter
branch
2 times, most recently
from
a97e4a5 to
0e3ede7
Compare
elia
force-pushed
the
elia/rspec-junit-formatter
branch
from
0e3ede7 to
8c91235
Compare
This will properly configure the spec task to depend on the test app, setting lib_name and the junit rspec formatter to be compatible with the official CircleCI ORB for Solidus extensions.
elia
force-pushed
the
elia/rspec-junit-formatter
branch
2 times, most recently
from
9e2a9bb to
364dbea
Compare
aldesantis
approved these changes
Nov 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a place in which extension development related tasks can be added and properly sets up the Rspec and test_app tasks. Includes the test-results configuration required by the Solidus CircleCI ORB.
Fixes #6