Skip to content

Replace selenium-webdriver with apparition#23

Merged
elia merged 4 commits intomasterfrom
elia/apparition
Dec 6, 2019
Merged

Replace selenium-webdriver with apparition#23
elia merged 4 commits intomasterfrom
elia/apparition

Conversation

@elia
Copy link
Copy Markdown
Member

@elia elia commented Nov 29, 2019

Fixes #22

There are also a couple of fixes for #17 that were dropped in an attempt to have less/simpler code, but were actually important.

elia added 3 commits November 29, 2019 17:24
This way it won't try to re-create it if the directory is already
there.
The test_app task changes the current working directory, when ran
before the rspec task it will make it not find any spec.
@elia elia added bug Describes or fixes a bug. enhancement Improves an existing feature. labels Nov 29, 2019
@elia elia requested a review from aldesantis November 29, 2019 16:37
@elia elia self-assigned this Nov 29, 2019
Apparition is modern, uses chrome headleass without requiring
chromedriver, and is developed by the current maintainer of capybara.
@elia elia merged commit ce98e83 into master Dec 6, 2019
@elia elia deleted the elia/apparition branch December 6, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Describes or fixes a bug. enhancement Improves an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move from selenium to apparition for JS feature specs

2 participants