Allow loading of factories from namespaced extensions#207
Merged
elia merged 1 commit intosolidusio:masterfrom Jun 9, 2023
Merged
Allow loading of factories from namespaced extensions#207elia merged 1 commit intosolidusio:masterfrom
elia merged 1 commit intosolidusio:masterfrom
Conversation
mergify
Bot
added
the
needs changelog label
Contributor
|
It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:
Additionally, the maintainer may also want to add one of the following:
Once the correct labels have been set, simply remove the |
forkata
added a commit
to SuperGoodSoft/solidus_taxjar
that referenced
this pull request
May 11, 2023
This change updates our extension to use the new method provided by `solidus_dev_support` instead of manually requiring the files. This is in line with how `FactoryBot` recommends factories are registered and resolves an issue with our custom override for the `Spree::Address` factory. Currently the upstream version of `solidus_dev_support` does not handle our use case of having a two folder deep namespace, so this change needs to wait for that to be fixed. We have opened a PR upstream for that to be changed - solidusio/solidus_dev_support#207 Co-authored-by: Nick Van Doorn <nick@super.gd>
Contributor
Author
|
This has to be rebased on #204 for tests to run, but that branch is currently failing CI. |
forkata
added a commit
to SuperGoodSoft/solidus_taxjar
that referenced
this pull request
May 19, 2023
This is a temporary fix until our PR to `solidus_dev_support` is merged that allows us to have deeper namespacing of the extension folder structure. solidusio/solidus_dev_support#207 Co-authored-by: Nick Van Doorn <nick@super.gd>
forkata
added a commit
to SuperGoodSoft/solidus_taxjar
that referenced
this pull request
May 19, 2023
This is a temporary fix until our PR to `solidus_dev_support` is merged that allows us to have deeper namespacing of the extension folder structure. solidusio/solidus_dev_support#207 Co-authored-by: Nick Van Doorn <nick@super.gd>
The previous glob did not allow there to be more than one level of namespacing in the extension file structure. This change will support extensions that have their factories in folder like `lib/super_good/solidus_taxjar/testing_support/factories/*`. Co-authored-by: Nick Van Doorn <nick@super.gd>
forkata
force-pushed
the
add-support-for-namespaced-extensions
branch
from
33b9dd8 to
3e6b7ca
Compare
forkata
added a commit
to SuperGoodSoft/solidus_taxjar
that referenced
this pull request
May 24, 2023
This is a temporary fix until our PR to `solidus_dev_support` is merged that allows us to have deeper namespacing of the extension folder structure. solidusio/solidus_dev_support#207 Co-authored-by: Nick Van Doorn <nick@super.gd>
elia
approved these changes
Jun 9, 2023
Member
|
Thanks, good catch! |
2 tasks
forkata
added a commit
to SuperGoodSoft/solidus_taxjar
that referenced
this pull request
Oct 17, 2023
This change updates our extension to use the new method provided by `solidus_dev_support` instead of manually requiring the files. This is in line with how `FactoryBot` recommends factories are registered and resolves an issue with our custom override for the `Spree::Address` factory. Currently the upstream version of `solidus_dev_support` does not handle our use case of having a two folder deep namespace, so this change needs to wait for that to be fixed. We have opened a PR upstream for that to be changed - solidusio/solidus_dev_support#207 Co-authored-by: Nick Van Doorn <nick@super.gd>
forkata
added a commit
to SuperGoodSoft/solidus_taxjar
that referenced
this pull request
Oct 17, 2023
This change updates our extension to use the new method provided by `solidus_dev_support` instead of manually requiring the files. This is in line with how `FactoryBot` recommends factories are registered and resolves an issue with our custom override for the `Spree::Address` factory. Currently the upstream version of `solidus_dev_support` does not handle our use case of having a two folder deep namespace, so this change needs to wait for that to be fixed. We have opened a PR upstream for that to be changed - solidusio/solidus_dev_support#207 Co-authored-by: Nick Van Doorn <nick@super.gd>
forkata
added a commit
to SuperGoodSoft/solidus_taxjar
that referenced
this pull request
Oct 31, 2023
This change updates our extension to use the new method provided by `solidus_dev_support` instead of manually requiring the files. This is in line with how `FactoryBot` recommends factories are registered and resolves an issue with our custom override for the `Spree::Address` factory. Currently the upstream version of `solidus_dev_support` does not handle our use case of having a two folder deep namespace, so this change needs to wait for that to be fixed. We have opened a PR upstream for that to be changed - solidusio/solidus_dev_support#207 Co-authored-by: Nick Van Doorn <nick@super.gd>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous glob did not allow there to be more than one level of namespacing in the extension file structure when loading factories.
This change will support extensions that have their factories in a folder structure like
lib/super_good/solidus_taxjar/testing_support/factories/*.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: