Skip to content

Adapt to latest Solidus release#204

Merged
mergify[bot] merged 3 commits intomasterfrom
waiting-for-dev/solidus_main
May 22, 2023
Merged

Adapt to latest Solidus release#204
mergify[bot] merged 3 commits intomasterfrom
waiting-for-dev/solidus_main

Conversation

@waiting-for-dev
Copy link
Copy Markdown
Contributor

@waiting-for-dev waiting-for-dev commented Apr 24, 2023 •
edited
Loading

Summary

Stop trying to pull solidus_frontend v4, which doesn't exist.

Adopt new Solidus default branch. Ref. solidusio/solidus#5042

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@waiting-for-dev waiting-for-dev self-assigned this Apr 24, 2023
@mergify mergify Bot added the needs changelog label Needs a label to determine the type of change. label Apr 24, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 24, 2023

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

@waiting-for-dev waiting-for-dev added infrastructure Internal change — changelog entry not needed. and removed needs changelog label Needs a label to determine the type of change. labels Apr 24, 2023
@waiting-for-dev waiting-for-dev mentioned this pull request Apr 24, 2023
Closed
19 tasks
kennyadsl
kennyadsl approved these changes Apr 26, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a PR ready that fixes specs. That PR will probably need a major bump but I'm not sure yet it's the right thing to do but if that's the case probably we can release this change along with the major bump.

@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/solidus_main branch from 572fb4b to 22c60b1 Compare May 9, 2023 13:27
This was referenced May 11, 2023
Closed
Merged
@forkata
Copy link
Copy Markdown
Contributor

forkata commented May 15, 2023 •
edited
Loading

@kennyadsl Any reason we can't merge this so we can get tests running at least against older versions of Solidus and work on getting tests passing against master main in a separate PR?

@kennyadsl
Copy link
Copy Markdown
Member

kennyadsl commented May 22, 2023

I think we can move this forward now @waiting-for-dev, isn't it?

@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/solidus_main branch from 22c60b1 to e9b8f72 Compare May 22, 2023 14:19
@waiting-for-dev waiting-for-dev marked this pull request as ready for review May 22, 2023 14:24
@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/solidus_main branch from e9b8f72 to b580bd8 Compare May 22, 2023 14:27
@waiting-for-dev waiting-for-dev changed the title Adapt new Solidus default branch Adapt to latest Solidus release May 22, 2023
@waiting-for-dev waiting-for-dev force-pushed the waiting-for-dev/solidus_main branch from b580bd8 to 14a0ba8 Compare May 22, 2023 14:44
@mergify mergify Bot merged commit a30e98a into master May 22, 2023
@mergify mergify Bot deleted the waiting-for-dev/solidus_main branch May 22, 2023 15:08
@waiting-for-dev
Copy link
Copy Markdown
Contributor Author

waiting-for-dev commented May 22, 2023

Done! Please, let us know if there's any problem.

forkata pushed a commit to SuperGoodSoft/solidus_dev_support that referenced this pull request Mar 12, 2026
@waiting-for-dev
Merge pull request solidusio#204 from solidusio/waiting-for-dev/solid…
f5d12fe 
…us_main

Adapt to new Solidus default branch name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@rainerdema rainerdema rainerdema approved these changes

@elia elia Awaiting requested review from elia

Assignees

@waiting-for-dev waiting-for-dev

Labels

infrastructure Internal change — changelog entry not needed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@waiting-for-dev @forkata @kennyadsl @rainerdema