Skip to content

Update circle.ci configuration for branch name#208

Closed
forkata wants to merge 1 commit intosolidusio:masterfrom
forkata:chore/update-ci-config-for-new-orb
Closed

Update circle.ci configuration for branch name#208
forkata wants to merge 1 commit intosolidusio:masterfrom
forkata:chore/update-ci-config-for-new-orb

Conversation

@forkata
Copy link
Copy Markdown
Contributor

@forkata forkata commented May 11, 2023

Summary

Solidus' development branch is now called main and as a result the CI
Orb was updated with jobs to reflect that. This renames the workflow to
reflect the change in the Orb as well as renames the job define in this
config to reflect that.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

Solidus' development branch is now called `main` and as a result the CI
orb was updated with jobs to reflect that. This renames the workflow to
reflect the change in the Orb as well as renames the job define in this
config to reflect that.
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 11, 2023

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

@mergify mergify Bot added the needs changelog label Needs a label to determine the type of change. label May 11, 2023
@forkata
Copy link
Copy Markdown
Contributor Author

forkata commented May 11, 2023

I didn't see that this is already in progress here, so going to close this as a duplicate #204

@forkata forkata closed this May 11, 2023
@forkata forkata deleted the chore/update-ci-config-for-new-orb branch January 3, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs changelog label Needs a label to determine the type of change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant