Skip to content

Open up the dependency for database cleaner#215

Merged
elia merged 3 commits intomainfrom
elia/solidus-main
Dec 28, 2023
Merged

Open up the dependency for database cleaner#215
elia merged 3 commits intomainfrom
elia/solidus-main

Conversation

@elia
Copy link
Copy Markdown
Member

@elia elia commented Dec 28, 2023

Summary

v1 is not compatible with Rails 7.1.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

v1 is not compatible with Rails 7.1.
@elia elia self-assigned this Dec 28, 2023
@mergify mergify Bot added the needs changelog label Needs a label to determine the type of change. label Dec 28, 2023
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Dec 28, 2023

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

@elia elia force-pushed the elia/solidus-main branch from 36b13d2 to 4a1e64d Compare December 28, 2023 16:08
@elia elia added infrastructure Internal change — changelog entry not needed. and removed needs changelog label Needs a label to determine the type of change. labels Dec 28, 2023
@elia elia marked this pull request as ready for review December 28, 2023 18:11
@elia elia merged commit 56da606 into main Dec 28, 2023
@elia elia deleted the elia/solidus-main branch December 28, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Internal change — changelog entry not needed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant