Skip to content

Open up the dependency for database cleaner #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elia merged 3 commits into from
Dec 28, 2023
Merged

Open up the dependency for database cleaner #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
157f95a
Open up the dependency for database cleaner
elia Dec 28, 2023
4a1e64d
Bump the required version of Ruby
elia Dec 28, 2023
030e43f
Fix rubocop warning
elia Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,22 +23,22 @@ jobs:
solidus-main:
executor:
name: solidusio_extensions/sqlite
ruby_version: '3.1'
ruby_version: '3.2'
steps: ['setup', 'solidusio_extensions/run-tests-solidus-main']
solidus-current:
executor:
name: solidusio_extensions/sqlite
ruby_version: '3.0'
ruby_version: '3.1'
steps: ['setup', 'solidusio_extensions/run-tests-solidus-current']
solidus-older:
executor:
name: solidusio_extensions/sqlite
ruby_version: '2.7'
ruby_version: '3.0'
steps: ['setup', 'solidusio_extensions/run-tests-solidus-older']
lint-code:
executor:
name: solidusio_extensions/sqlite
ruby_version: '3.0'
ruby_version: '3.1'
steps: ['setup', 'solidusio_extensions/lint-code']

workflows:
Expand Down
1 change: 0 additions & 1 deletion lib/solidus_dev_support/rake_tasks.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ def install_changelog_task
config.user = repo.owner
config.project = repo.name
config.future_release = "v#{ENV.fetch('UNRELEASED_VERSION') { gemspec.version }}"

rescue Octokit::InvalidRepository
warn <<~WARN
It won't be possible to automatically generate the CHANGELOG for this extension because the
Expand Down
4 changes: 2 additions & 2 deletions solidus_dev_support.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
spec.metadata['changelog_uri'] = 'https://github.com/solidusio/solidus_dev_support/releases'
spec.metadata['rubygems_mfa_required'] = 'true'

spec.required_ruby_version = '>= 2.5.0'
spec.required_ruby_version = '>= 3.0.0'

# Specify which files should be added to the gem when it is released.
# The `git ls-files -z` loads the files in the RubyGem that have been added into git.
Expand All @@ -32,7 +32,7 @@ Gem::Specification.new do |spec|
spec.add_dependency 'capybara', '~> 3.29'
spec.add_dependency 'capybara-screenshot', '~> 1.0'
spec.add_dependency 'codecov', '~> 0.2'
spec.add_dependency 'database_cleaner', '~> 1.7'
spec.add_dependency 'database_cleaner', ['>= 1.7', '< 3']
spec.add_dependency 'factory_bot', '>= 4.8'
spec.add_dependency 'factory_bot_rails'
spec.add_dependency 'ffaker', '~> 2.13'
Expand Down