Skip to content

Fix(specs): Correct path for gem in spec#223

Merged
mergify[bot] merged 2 commits intosolidusio:mainfrom
mamhoff:fix-gemspec-error
Dec 3, 2024
Merged

Fix(specs): Correct path for gem in spec#223
mergify[bot] merged 2 commits intosolidusio:mainfrom
mamhoff:fix-gemspec-error

Conversation

@mamhoff
Copy link
Copy Markdown
Contributor

@mamhoff mamhoff commented Dec 2, 2024

The dummy extension is being created in tmp/solidus_test_extension, which is two, not three folders above the working directory.

The following are mandatory for all PRs:

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Dec 2, 2024

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

@mergify mergify Bot added the needs changelog label Needs a label to determine the type of change. label Dec 2, 2024
@mamhoff mamhoff force-pushed the fix-gemspec-error branch 2 times, most recently from e8ecb95 to f1a6ebd Compare December 2, 2024 13:36
@tvdeyen tvdeyen added infrastructure Internal change — changelog entry not needed. and removed needs changelog label Needs a label to determine the type of change. labels Dec 2, 2024
@tvdeyen tvdeyen enabled auto-merge December 2, 2024 13:41
@tvdeyen
Copy link
Copy Markdown
Member

tvdeyen commented Dec 2, 2024

"How has this ever worked?" 🤔

auto-merge was automatically disabled December 2, 2024 14:33

Head branch was pushed to by a user without write access

@mamhoff mamhoff force-pushed the fix-gemspec-error branch 4 times, most recently from 915f0e4 to 55f29cd Compare December 3, 2024 15:08
The dummy extension is being created in `tmp/solidus_test_extension`,
which is two, not three folders above the working directory.
@mergify mergify Bot merged commit d02696e into solidusio:main Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Internal change — changelog entry not needed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants