Skip to content

Fix(specs): Correct path for gem in spec #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Dec 3, 2024
Merged

Fix(specs): Correct path for gem in spec #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e34610
Fix(specs): Correct path for gem in spec
mamhoff Dec 2, 2024
da8880e
Test: Re-create fix from Solidus PR 5991
mamhoff Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/solidus_dev_support/templates/extension/bin/sandbox.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ echo "~~~> Removing the old sandbox"
rm -rf ./sandbox

echo "~~~> Creating a pristine Rails app"
rails new sandbox \
rails_version=`bundle exec ruby -e'require "rails"; puts Rails.version'`
rails _${rails_version}_ new sandbox \
--database="${DB:-sqlite3}" \
--skip-git \
--skip-keeps \
Expand Down
6 changes: 1 addition & 5 deletions spec/features/create_extension_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,9 @@ def check_create_extension

def check_bundle_install
cd(install_path) do
open('Gemfile', 'a') { |f| f.puts "gem 'solidus_dev_support', path: '../../..'" }
open('Gemfile', 'a') { |f| f.puts "gem 'solidus_dev_support', path: '../..'" }
end

expect { bundle_install }.to raise_error(command_failed_error, /invalid gemspec/)

# Update gemspec with the required fields
gemspec_path = install_path.join(gemspec_name)
gemspec = gemspec_path.read.lines
Expand Down Expand Up @@ -139,9 +137,7 @@ def check_run_specs

def check_sandbox
cd(install_path) do
# rubocop:disable Lint/InterpolationCheck
command = 'bin/rails-sandbox runner "puts %{The version of SolidusTestExtension is #{SolidusTestExtension::VERSION}}"'
# rubocop:enable Lint/InterpolationCheck

first_run_output = sh(command)
expect(first_run_output).to include("Creating the sandbox app...")
Expand Down