Add support for new codecov uploader#226
Merged
tvdeyen merged 4 commits intosolidusio:mainfrom Feb 13, 2025
Merged
Conversation
Contributor
|
It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:
Additionally, the maintainer may also want to add one of the following:
Once the correct labels have been set, simply remove the |
mergify
Bot
added
the
needs changelog label
tvdeyen
added a commit
to solidusio-contrib/solidus_reviews
that referenced
this pull request
Feb 12, 2025
Remove after solidusio/solidus_dev_support#226 has been merged.
tvdeyen
added
enhancement
tvdeyen
force-pushed
the
new-codecov-uploader
branch
from
a4fd558 to
2ca5b1b
Compare
tvdeyen
force-pushed
the
new-codecov-uploader
branch
from
9b19fbb to
e3b2cb7
Compare
elia
approved these changes
Feb 13, 2025
Member
elia
left a comment
elia
left a comment
There was a problem hiding this comment.
Great! left some minor comments, pre-approving so you can merge right away after fixing them (if you agree).
tvdeyen
force-pushed
the
new-codecov-uploader
branch
from
bc50c70 to
f9ce51d
Compare
The ruby codecov uploader gem is deprecated in favor of the codecov cli. There is a GitHub action that can be used to upload the coverage report. Set the CODECOV_COVERAGE_PATH env var to use the simplecov-cobertura formatter. See: https://docs.codecov.com/docs/deprecated-uploader-migration-guide#ruby-uploader
We do not have full Rails 8.0 support yet
The fixes in Solidus are not available everywhere yet.
tvdeyen
force-pushed
the
new-codecov-uploader
branch
from
f9ce51d to
7520134
Compare
tvdeyen
force-pushed
the
new-codecov-uploader
branch
from
7520134 to
09d48f4
Compare
tvdeyen
added a commit
to solidusio/solidus_subscriptions
that referenced
this pull request
Feb 13, 2025
tvdeyen
added a commit
that referenced
this pull request
Feb 13, 2025
tvdeyen
force-pushed
the
new-codecov-uploader
branch
from
09d48f4 to
7ffa09f
Compare
Rails 7.2 onwards has support for sqlite 2 and this also allows sqlite >= 2.0 for Rails 8.0 tests.
tvdeyen
force-pushed
the
new-codecov-uploader
branch
from
7ffa09f to
396668f
Compare
tvdeyen
added a commit
to solidusio/solidus_subscriptions
that referenced
this pull request
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ruby codecov uploader gem is deprecated in favor of the codecov cli. There is a GitHub action that can be used to upload the coverage report.
Set the CODECOV_COVERAGE_PATH env var to use
the simplecov-cobertura formatter.
See: https://docs.codecov.com/docs/deprecated-uploader-migration-guide#ruby-uploader
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: