Conversation
bretthayes
left a comment
There was a problem hiding this comment.
Looks good! Dev and build tested and working! 🎉
However, I found some Blog Post Items in the list that don't seem to render the thumbnails horizontally inside the card, some excerpts show some code, and some of the links are broken and bring you to 404's. I won't list and screenshot all of them for the sake of time, but here's a few examples:
/powerful-code-search-for-bitbucket-serverscreenshot/liveblogging-dotgo-2017screenshot/liveblogging-graphql-summit-2017screenshot/advanced-testing-in-go/evolutionary-optimization-peter-bourgon
|
@bretthayes are the broken links you are seeing for images? I'm not seeing image 404s on the feed. Was that what you were talking about? |
|
@katjuell no, the images load fine in the cards but sometimes they're not horizontally columned. The blog posts themselves 404 after you click on the linked titles in the cards. |
|
Hmm @bretthayes — is it just liveblogs that are doing that for you? I am able to click through to normal posts from the top-level year/ date directories from the index — want to confirm that this is the case for you as well. So Update: This should be fixed now, in 62d6ad4 |
|
Sweet! Looks like those 404's are fixed now @katjuell. But now we have some other bugs. 😬 I'll try and explain my best to see if you can reproduce. I clicked the load more button to get all the way to the end, but at some point mid-way-down when more cards were rendered, the cards were rendering inside the excerpts. They started to look like this and this. We also have components now rendering in the excerpt and I think we want only text descriptions/excerpts. (screenshot and screenshot). |
|
Hey @bretthayes — yeah we have a bit of a crossroads here. I didn't see the cards rendering inside the excerpts, but the component rendering behavior I was aware of. Basically, the tl;dr is that we don't have access to the Gatsby plugin that was handling excerpts before (via the MD GraphQL API), so we have a few choices, none of them great:
What do you think? |
|
I think option 1 might be our best case atm until someone from content marketing can provide missing descriptions for option 3. I think we'll need those either way once we bring in Contentful right? @katjuell |
|
@bretthayes — yes, descriptions will be required! Or, at least, that's how I was thinking about it. We could do a similar thing to the excerpt here, where we query the blog post body with a character limit. But I would much rather have descriptions be a required field for this, personally |
|
Same same! Sounds good! I think we should grab the 100~ or so posts without descriptions, put them in a spreadsheet to hand off to content marketing and then request descriptions for them. In the mean time we can render the excerpt as a string and follow up in another ticket. @katjuell |
|
Works for me! |
|
Thanks for all of your thoughtful feedback @bretthayes!! As always :) |
Closes #58 by adding the blog index and new load more logic (to avoid the dreaded infinite scroll).
Also removes links to Liveblogs, related types etc.
Spreadsheet outlining which posts have descriptions and which do not (as of 4/26/2022)
To Test
/blogand make sure loading logic works correctly.