Skip to content
This repository was archived by the owner on May 24, 2022. It is now read-only.

Add blog index#112

Merged
katjuell merged 17 commits intomainfrom
kjuell/blog-index
Apr 28, 2022
Merged

Add blog index#112
katjuell merged 17 commits intomainfrom
kjuell/blog-index

Conversation

@katjuell
Copy link
Contributor

@katjuell katjuell commented Apr 13, 2022

Closes #58 by adding the blog index and new load more logic (to avoid the dreaded infinite scroll).

Also removes links to Liveblogs, related types etc.

Spreadsheet outlining which posts have descriptions and which do not (as of 4/26/2022)

To Test

  • Visit /blog and make sure loading logic works correctly.
  • Test static builds

@katjuell katjuell added the team/content-platform Content Platform Team related tickets. label Apr 13, 2022
@katjuell katjuell added this to the AR - Sprint 2 milestone Apr 13, 2022
@katjuell katjuell self-assigned this Apr 13, 2022
Copy link
Contributor

@bretthayes bretthayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Dev and build tested and working! 🎉

However, I found some Blog Post Items in the list that don't seem to render the thumbnails horizontally inside the card, some excerpts show some code, and some of the links are broken and bring you to 404's. I won't list and screenshot all of them for the sake of time, but here's a few examples:

  • /powerful-code-search-for-bitbucket-server screenshot
  • /liveblogging-dotgo-2017 screenshot
  • /liveblogging-graphql-summit-2017 screenshot
  • /advanced-testing-in-go
  • /evolutionary-optimization-peter-bourgon

@katjuell
Copy link
Contributor Author

@bretthayes are the broken links you are seeing for images? I'm not seeing image 404s on the feed. Was that what you were talking about?

@bretthayes
Copy link
Contributor

@katjuell no, the images load fine in the cards but sometimes they're not horizontally columned. The blog posts themselves 404 after you click on the linked titles in the cards.

@katjuell
Copy link
Contributor Author

katjuell commented Apr 19, 2022

Hmm @bretthayes — is it just liveblogs that are doing that for you? I am able to click through to normal posts from the top-level year/ date directories from the index — want to confirm that this is the case for you as well. So /blog/strange-loop/strange-loop-2019-how-your-company-can-help-sustain-open-source works but /blog/strange-loop-2019-how-your-company-can-help-sustain-open-source does not, and /blog/sourcegraph-founders-featured-on-forbes-30-under-30-list from 2017 works as is (so all year/date directory links from index are correct)

Update: This should be fixed now, in 62d6ad4

@katjuell katjuell requested a review from bretthayes April 19, 2022 22:59
@bretthayes
Copy link
Contributor

Sweet! Looks like those 404's are fixed now @katjuell. But now we have some other bugs. 😬

I'll try and explain my best to see if you can reproduce. I clicked the load more button to get all the way to the end, but at some point mid-way-down when more cards were rendered, the cards were rendering inside the excerpts. They started to look like this and this.

We also have components now rendering in the excerpt and I think we want only text descriptions/excerpts. (screenshot and screenshot).

@katjuell
Copy link
Contributor Author

Hey @bretthayes — yeah we have a bit of a crossroads here. I didn't see the cards rendering inside the excerpts, but the component rendering behavior I was aware of. Basically, the tl;dr is that we don't have access to the Gatsby plugin that was handling excerpts before (via the MD GraphQL API), so we have a few choices, none of them great:

  • Render excerpts as strings (all MD will not be formatted)
  • Render MD (where we will have components and headers and the like)
  • Fill out any records that don't have descriptions with descriptions (a little under 100 records)
  • Use a placeholder description for all records that don't have a description in place.

What do you think?

@bretthayes
Copy link
Contributor

bretthayes commented Apr 20, 2022

I think option 1 might be our best case atm until someone from content marketing can provide missing descriptions for option 3. I think we'll need those either way once we bring in Contentful right? @katjuell

@katjuell
Copy link
Contributor Author

@bretthayes — yes, descriptions will be required! Or, at least, that's how I was thinking about it. We could do a similar thing to the excerpt here, where we query the blog post body with a character limit. But I would much rather have descriptions be a required field for this, personally

@bretthayes
Copy link
Contributor

Same same! Sounds good! I think we should grab the 100~ or so posts without descriptions, put them in a spreadsheet to hand off to content marketing and then request descriptions for them. In the mean time we can render the excerpt as a string and follow up in another ticket. @katjuell

@katjuell
Copy link
Contributor Author

Works for me!

Copy link
Contributor

@bretthayes bretthayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nailed it! Thanks for all your hard efforts on all of this!

@katjuell
Copy link
Contributor Author

Thanks for all of your thoughtful feedback @bretthayes!! As always :)

@katjuell katjuell merged commit b0c3203 into main Apr 28, 2022
@katjuell katjuell deleted the kjuell/blog-index branch April 28, 2022 19:44
@bretthayes bretthayes mentioned this pull request May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team/content-platform Content Platform Team related tickets.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Add Blog index

2 participants