Skip to content
This repository was archived by the owner on May 24, 2022. It is now read-only.

Port/code health use case#142

Merged
zlonko merged 15 commits intomainfrom
port/code-health-use-case
May 9, 2022
Merged

Port/code health use case#142
zlonko merged 15 commits intomainfrom
port/code-health-use-case

Conversation

@zlonko
Copy link
Contributor

@zlonko zlonko commented May 4, 2022 •
edited
Loading

This closes #132. It ports over the Code Health Use Case page, as well as a few related changes.

The original PR: #5274.

Notes

  • Ports over the Code Health Use Case page
  • Implements white navbar on Code Health, Vulnerabilities, and Onboarding
  • Adds the ThreeUpText component as well as alt text on BlogListItem
  • A lot changed for the new CustomerLogos component in the new homepage PR. To keep within the scope of this issue, CustomerLogosSectionAnimated is used with the intent to port over CustomerLogos with the homepage.

Testing

  • Check out /use-cases/code-health
  • Please check that links on use-cases/code-health and use-cases work as expected

@zlonko zlonko added the team/content-platform Content Platform Team related tickets. label May 4, 2022
@zlonko zlonko self-assigned this May 4, 2022
@zlonko zlonko marked this pull request as ready for review May 5, 2022 14:45
@zlonko zlonko requested review from bretthayes and st0nebreaker May 5, 2022 14:46
@zlonko zlonko mentioned this pull request May 5, 2022
Closed
zlonko
zlonko commented May 5, 2022
View reviewed changes
src/components/Blockquote.tsx Outdated
<figcaption className="text-center text-muted">&mdash; {author}</figcaption>
</>
)}
<blockquote className="px-3 mb-5 text-center border-left-red">
Copy link
Contributor Author

@zlonko zlonko May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This updates which Blockquote is used. By reading Becca's PR #143, I noticed what I did in Blockquote was redundant with BlockquoteWithBorder.

Copy link
Contributor

@bretthayes bretthayes May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out this commit for the changes regarding the border utility class

@zlonko
Copy link
Contributor Author

zlonko commented May 5, 2022 •
edited
Loading

Hey @bretthayes and @st0nebraker: I noticed a few things were off in this PR after reviewing #143. I am going to revise those and re-notify you once its ready again for review.

Edit: It makes sense to hold on this until Code Reuse is merged. This way, we can improve this layout with the ThreeUpText and BlogListItem components found there. (Mentioned in review)

@zlonko zlonko mentioned this pull request May 5, 2022
Merged
bretthayes
bretthayes reviewed May 6, 2022
View reviewed changes
Copy link
Contributor

@bretthayes bretthayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good @zlonko! Feel free to trigger a re-review when you're ready again for a review after #143 is merged.

@bretthayes bretthayes added this to the AR - Sprint 3 milestone May 9, 2022
@zlonko zlonko requested a review from bretthayes May 9, 2022 16:33
st0nebreaker
st0nebreaker approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@st0nebreaker st0nebreaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One comment below, not blocking though

src/pages/use-cases/index.tsx Outdated
</Link>
<Link href="/use-cases/code-health" passHref={true}>
{/* eslint-disable-next-line jsx-a11y/anchor-is-valid */}
<a className="btn btn-link font-weight-bold">Learn more</a>
Copy link
Contributor

@st0nebreaker st0nebreaker May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm realizing since Brett's homepage PR makes all a tags have bold font, we should get rid of redundant inline bold styles on a tags like here. My last PR probably had these too. We can make another story for this cleanup if it's out of scope for this PR.

Copy link
Contributor Author

@zlonko zlonko May 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, let's remove them here! I updated them in 9a0f3af. Thank you!

@zlonko zlonko merged commit 2c6c722 into main May 9, 2022
@zlonko zlonko deleted the port/code-health-use-case branch May 9, 2022 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bretthayes bretthayes Awaiting requested review from bretthayes

1 more reviewer

@st0nebreaker st0nebreaker st0nebreaker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zlonko zlonko

Labels

team/content-platform Content Platform Team related tickets.

Projects

No open projects
Content Platform Work
Status: Done ✅

Milestone

AR - Sprint 3

Development

Successfully merging this pull request may close these issues.

Port/ Code Health Use Case

3 participants

@zlonko @bretthayes @st0nebreaker