This repository was archived by the owner on Sep 11, 2025. It is now read-only.
Incident response use case /non-blocking feedback#5297
Merged
bretthayes merged 46 commits intomainfrom May 11, 2022
Merged
Conversation
zlonko
added
team/content-platform
marketing-request
Contributor
Author
|
@elzannewentzel This is almost ready for Engineering review. Two comments about the "Incident response is stressful and overwhelming" section are unresolved, so I left a follow-up reply in the doc. Edit: All clear! |
Contributor
Merged
…use-case-non-blocking
Contributor
Author
|
@elzannewentzel To keep things moving today, and because we are awaiting feedback on non-blocking feedback here, I went ahead and deployed #5259 with the intent to push this branch into main once it is ready. |
bretthayes
suggested changes
May 10, 2022
Contributor
bretthayes
left a comment
bretthayes
left a comment
There was a problem hiding this comment.
Looks like there's a merge conflict to fix. After that, I think this should be good to go.
Contributor
Author
|
Nice! I resolved the conflict. It looks about ready for your final take @bretthayes! |
bretthayes
approved these changes
May 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #5287. Here, we implement the remaining feedback from our Marketing stakeholders, re: copy updates, a changed icon, and logo treatment.
The QA doc can be found here.
Notes
CustomCarouselTesting
use-cases/incident-response