feat: support Sourcegraph extensions in the new inject code#199
feat: support Sourcegraph extensions in the new inject code#199
Conversation
| extensionsController: ClientController<ConfigurationSubject, Settings> | ||
| extensionsContextController: Controller<ConfigurationSubject, Settings> | ||
| }): void { | ||
| const headerElem = document.querySelector('div.HeaderMenu>div:last-child') |
There was a problem hiding this comment.
@chrismwendt This isn't abstract. Nothing inside libs/code_intelligence should know anything code host specific. That's why I had created a getCommandPaletteMount function that the code host has to implement.
There was a problem hiding this comment.
Oh right, that was unintentional and definitely should be factored out.
|
|
||
| interface Controllers { | ||
| ctx: Controller<ConfigurationSubject, Settings> | ||
| ctl: ClientController<ConfigurationSubject, Settings> |
There was a problem hiding this comment.
Could we have a little more specific names/doc blocks? Since the interface is named Controllers, ctx and ctl just confuses me especially considering the types look like they indeed are both controllers
ijsnow
force-pushed
the
ext-new-inject
branch
from
b959c25 to
8190002
Compare
|
This PR breaks the extensions list in the options page (due to sourcegraph/extensions-client-common@7f1d38c which got into e-c-c v8.6.0, and this PR bumps to v8.8.0). I'm working on fixing this now. |
ijsnow
changed the title
|
TODO: Implement |
|
Fixed the extensions list page and pushed. |
ijsnow
changed the title
|
🎉 This PR is included in version 1.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
newInjectfeature flag