Skip to content
This repository was archived by the owner on Jan 22, 2019. It is now read-only.

feat: always use Sourcegraph extensions, remove feature flag#272

Open
sqs wants to merge 1 commit intomasterfrom
always-use-extensions
Open

feat: always use Sourcegraph extensions, remove feature flag#272
sqs wants to merge 1 commit intomasterfrom
always-use-extensions

Conversation

@sqs
Copy link
Member

@sqs sqs commented Oct 25, 2018

Removes the feature flag to toggle between whether to use Sourcegraph extensions and not. Sourcegraph extensions will always be used.

@ijsnow I opened this up per https://sourcegraph.slack.com/archives/C07KZF47K/p1540456636000100?thread_ts=1540453431.000100&cid=C07KZF47K. What else is necessary before we can merge it? Are there any other old code paths to remove?

Feel free to take over this PR.

Removes the feature flag to toggle between whether to use Sourcegraph extensions and not. Sourcegraph extensions will always be used.
@sqs sqs requested a review from ijsnow as a code owner October 25, 2018 10:23
@sqs sqs changed the title October 2018 feat: always use Sourcegraph extensions, remove feature flag Oct 25, 2018
@sqs sqs added this to the October 2018 milestone Oct 25, 2018
Copy link

@ijsnow ijsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for now. There will be a lot more code removed once all code hosts have extension support and implement the CodeHost interface.

@ijsnow
Copy link

ijsnow commented Oct 25, 2018

Rethinking, we should consider waiting until I get at least the second bullet point done here https://github.com/sourcegraph/browser-extensions/issues/273.

It looks like e2e tests passed in CI but I've ran them 4 times locally now and they've failed 1/4 times in different places. Could be due to wake up time for the lang server extensions?

@chrismwendt
Copy link

Here's how to move this PR to https://github.com/sourcegraph/sourcegraph/tree/master/packages/browser-extensions

cd browser-extensions
git format-patch master --stdout > /tmp/patch

cd ../sourcegraph
cat /tmp/patch | git am -3 --directory=packages/browser-extensions/
# and fixup merge conflicts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants