This repository was archived by the owner on Jan 22, 2019. It is now read-only.
feat: always use Sourcegraph extensions, remove feature flag#272
Open
feat: always use Sourcegraph extensions, remove feature flag#272
Conversation
Removes the feature flag to toggle between whether to use Sourcegraph extensions and not. Sourcegraph extensions will always be used.
ijsnow
approved these changes
Oct 25, 2018
ijsnow
left a comment
There was a problem hiding this comment.
This looks good for now. There will be a lot more code removed once all code hosts have extension support and implement the CodeHost interface.
|
Rethinking, we should consider waiting until I get at least the second bullet point done here https://github.com/sourcegraph/browser-extensions/issues/273. It looks like e2e tests passed in CI but I've ran them 4 times locally now and they've failed 1/4 times in different places. Could be due to wake up time for the lang server extensions? |
|
Here's how to move this PR to https://github.com/sourcegraph/sourcegraph/tree/master/packages/browser-extensions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the feature flag to toggle between whether to use Sourcegraph extensions and not. Sourcegraph extensions will always be used.
@ijsnow I opened this up per https://sourcegraph.slack.com/archives/C07KZF47K/p1540456636000100?thread_ts=1540453431.000100&cid=C07KZF47K. What else is necessary before we can merge it? Are there any other old code paths to remove?
Feel free to take over this PR.