feat: browser extension testing project rough draft#48
Conversation
sqs
left a comment
sqs
left a comment
There was a problem hiding this comment.
Thank you for opening a doc on this! I added some comments. I am glad you brought this up.
| way their APIs work at any time and runs across many code | ||
| hosts, any of which could change their DOM, thus breaking our extension. | ||
|
|
||
| Reliability is important to us and our users, so we're building up the testing |
There was a problem hiding this comment.
What are the requirements for you to feel comfortable enabling Sourcegraph extensions for all (removing the feature flag)? Is your comment sourcegraph/browser-extensions#272 (comment) still current? If so, please explicitly state those conditions/requirements here, because that's the main piece of info the folks working on extensions will want to know from this doc.
|
|
||
| - Run each test on all supported code hosts - code hosts won't be considered | ||
| fully supported until we're able to run tests on it | ||
| - Test with different feature flags enabled or disabled |
There was a problem hiding this comment.
We should remove some features and feature flags while we're at it:
- ✔️ inline symbol search has proven stable and not to interfere, so remove feature flag and enable by default /cc @ggilmore (I also would like to extend and promote this feature more, and make it so extensions can contribute to it!) <-- if this delays your work on this project, then you can punt
- ❌ remove GitHub file tree navigation. Some people use this, but it is not the killer feature of our extension. Octotree does it better and does it for private code more easily than us. We also won't be providing this for other code hosts, and I want to minimize the number of features we have that are only for a single code host (it confuses users and makes them feel 2nd-class).
- ❌ remove the feature "Open a new window with Sourcegraph search results" because users didn't like it
- keep "Render mermaid.js" diagrams" as a feature flag as is
| @@ -0,0 +1,25 @@ | |||
| # Browser extension testing and reliability | |||
There was a problem hiding this comment.
You intend to work on this immediately after shipping sourcegraph/browser-extensions#271, right? (Do you have an ETA on merging that PR?) That sounds right to me. I already moved the rest of "Better config and depoyment for code host UI integrations" to November 2018 on https://docs.sourcegraph.com/dev/roadmap#november-2018 and split out the options page blog post to #46.
There was a problem hiding this comment.
Correct. I just have to pull in access token changes that I made the other day into the new options menu.
2 participants
No description provided.