This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Closed
Conversation
Codecov Report
|
sqs
reviewed
Oct 26, 2018
|
|
||
| Feature | 🔗 | Themes/products | Team | ||
| ------- | --- | -------- | ---- | ||
| Browser extension testing and reliability | [📣](https://github.com/sourcegraph/about/pull/48) | Integrations, [Sourcegraph][sourcegraph], [browser extension][browser-extensions] | [@ijsnow][ijsnow] |
Member
There was a problem hiding this comment.
Can you finish the requirements for enabling Sourcegraph extensions for all (sourcegraph/about#48 (comment)) next week? Mentioning it here because I see this whole thing is under November 2018, but we would like to be able to enable Sourcegraph extensions for all sooner than that.
BolajiOlajide
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Only checkout repo archive if steps will be executed Since we use a "reference counting" mechanism when checking out archives we shouldn't bump the ref count if we never execute steps. Because only after executing the steps do we decrease the ref count and thus "free" the archive to be cleaned up. The problem is that if a `Task` has a cache hit then the ref will never be decreased and the archive never cleaned up. * WIP is working * More tiny refactoring * Working state * Move stuff around * More refactoring * Improve caching messages after feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds browser extension testing to the roadmap.