Skip to content
This repository was archived by the owner on Jan 22, 2019. It is now read-only.

feat: pass sourcegraphURL and clientApplication to extensions#281

Merged
sqs merged 1 commit intomasterfrom
sourcegraph-url
Oct 29, 2018
Merged

feat: pass sourcegraphURL and clientApplication to extensions#281
sqs merged 1 commit intomasterfrom
sourcegraph-url

Conversation

@sqs
Copy link
Member

@sqs sqs commented Oct 29, 2018

This PR changes:

Testing plan:

  • Test the sourcegraph/git-extras extension on GitHub with and without this change. With this change, the URLs should be correct (to https://sourcegraph.com/..., not relative).

I have tested on:

  • Chrome
  • Firefox
  • Safari
  • Phabricator Bundle

@sqs sqs requested a review from ijsnow as a code owner October 29, 2018 02:43
@sqs sqs force-pushed the sourcegraph-url branch from 9029a58 to 1ea6bb6 Compare October 29, 2018 02:49
@sqs sqs merged commit 7eef3c8 into master Oct 29, 2018
@sqs sqs deleted the sourcegraph-url branch October 29, 2018 03:24
@sourcegraph-bot
Copy link

🎉 This PR is included in version 1.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants