Skip to content
This repository was archived by the owner on Nov 6, 2018. It is now read-only.

feat: supply sourcegraphURL and clientApplication to extensions#111

Merged
sqs merged 1 commit intomasterfrom
sourcegraph-url-and-client-app
Oct 29, 2018
Merged

feat: supply sourcegraphURL and clientApplication to extensions#111
sqs merged 1 commit intomasterfrom
sourcegraph-url-and-client-app

Conversation

@sqs
Copy link
Member

@sqs sqs commented Oct 29, 2018

In some cases, such as to work around https://github.com/sourcegraph/sourcegraph/issues/566, it is useful for extensions to know the Sourcegraph URL and what kind of client application is running it.

In some cases, such as to work around sourcegraph/sourcegraph#566, it is useful for extensions to know the Sourcegraph URL and what kind of client application is running it.
@codecov
Copy link

codecov bot commented Oct 29, 2018

Codecov Report

Merging #111 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   77.58%   77.58%           
=======================================
  Files          67       67           
  Lines        2628     2628           
  Branches      534      534           
=======================================
  Hits         2039     2039           
  Misses        589      589
Impacted Files Coverage Δ
src/extension/extensionHost.ts 87.5% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5973a14...d927137. Read the comment docs.

@sqs sqs merged commit fd90209 into master Oct 29, 2018
@sqs sqs deleted the sourcegraph-url-and-client-app branch October 29, 2018 02:41
sqs added a commit to sourcegraph/browser-extensions that referenced this pull request Oct 29, 2018
@sourcegraph-bot
Copy link

🎉 This PR is included in version 18.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

sqs added a commit to sourcegraph/browser-extensions that referenced this pull request Oct 29, 2018
sqs added a commit to sourcegraph/browser-extensions that referenced this pull request Oct 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants