This repository was archived by the owner on Aug 8, 2019. It is now read-only.
feat: unsubscribe providers when queryLSP throws an error#8
Merged
chrismwendt merged 1 commit intomasterfrom Oct 18, 2018
Merged
feat: unsubscribe providers when queryLSP throws an error#8chrismwendt merged 1 commit intomasterfrom
chrismwendt merged 1 commit intomasterfrom
Conversation
sqs
approved these changes
Oct 17, 2018
chrismwendt
added a commit
that referenced
this pull request
Nov 7, 2018
This reverts commit 9e9bb73.
chrismwendt
added a commit
that referenced
this pull request
Nov 13, 2018
This reverts commit 9e9bb73.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm planning to support running extensions (e.g. Codecov) on private code even when the repository does not exist on the Sourcegraph instance. Doing so will resolve this issue: https://github.com/sourcegraph/browser-extensions/issues/234#issuecomment-430429015
That means that all extensions will run, including language extensions. Unfortunately, when the repository doesn't exist, every hover will 404 and show up in the hover tooltip, which is pretty annoying.
To avoid so many errors popping up in the hover tooltips, this PR suppresses 404s and other network errors so that they do not show up in tooltips but still show up in the console. Errors returned by the language server will still show up in the hover tooltips.