This repository was archived by the owner on Aug 8, 2019. It is now read-only.
Do not stop the extension upon an error#9
Merged
chrismwendt merged 1 commit intomasterfrom Nov 13, 2018
Merged
Conversation
This was referenced Nov 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8 both suppressed errors and caused the extension to stop serving code intelligence upon the first error.
This PR makes the extension keep serving code intelligence even when errors occur, and will fix the customer-reported issue https://github.com/sourcegraph/sourcegraph/issues/838
Consequently, on private code, an error will get logged to to the console whenever a hover occurs. This is an acceptable tradeoff until a better solution arises (e.g. checking if the current repo is private and the Sourcegraph URL is set to Sourcegraph.com, or otherwise checking if code intelligence is expected to work at all).