Prepare CLI for extension sunsetting #825
Conversation
philipp-spiess
requested review from
eseliger,
jjinnii,
muratsu,
ryankscott,
taras-yemets and
vdavid
| EXPERIMENTAL: Extensions are experimental functionality on Sourcegraph and in the 'src' tool. | ||
| DEPRECATED: We're in the process of removing Sourcegraph extensions with our September release. | ||
| Learn more: https://docs.sourcegraph.com/extensions/deprecation |
There was a problem hiding this comment.
There was a problem hiding this comment.
Do you want this to go out in a 3.43.x version?
There was a problem hiding this comment.
I think we do, since we are also shipping this already on sourcegraph.com but this is a questions for the above people to answer 🙈
There was a problem hiding this comment.
Ok, just let me know when you have a decision, since I already cut 3.43.0 for the branch cut this evening, but can cut 3.43.1 right after merge.
There was a problem hiding this comment.
Ah, I see. I don't think it's super urgent to get this out with 3.43 (the more important messaging is going out on the web app anyway), so I don't think we need to cut a minor release for that 🙂
| EXPERIMENTAL: Extensions are experimental functionality on Sourcegraph and in the 'src' tool. | ||
| DEPRECATED: We're in the process of removing Sourcegraph extensions with our September release. | ||
| Learn more: https://docs.sourcegraph.com/extensions/deprecation |
There was a problem hiding this comment.
Do you want this to go out in a 3.43.x version?
Part of sourcegraph/sourcegraph#39044
Part of sourcegraph/sourcegraph#39043
While auditing the CLI functionality and requirements for the upcoming extensions deprecation, I noticed two areas that are currently not working well:
sg extensionscommand doesn't explain the upcoming deprecation yet. I've changed it to show the same text as sourcegraph.com cc @jjinnii @ryankscott @muratsusg extensions listcommand did not forward the GraphQL error probably. This happens because the endpoint does not use the normal GraphQL error pattern for errors. See this for more context.All other extension endpoints work as expected and I made sure they forward an error message sent on the backend (I'll follow up with the backend changes to gate out the APIs in a separate commit [lol obviously because this is a different repo haha]).
Test plan