Skip to content

Prepare CLI for extension sunsetting #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philipp-spiess merged 3 commits into from
Aug 17, 2022
Merged

Prepare CLI for extension sunsetting #825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
323671d
Improve wording for `sg extensions` command
philipp-spiess Aug 17, 2022
027f0d4
Pass-through error messages for `sg extensions list` query
philipp-spiess Aug 17, 2022
7f74187
Fix indentation
philipp-spiess Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cmd/src/extensions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ var extensionsCommands commander
func init() {
usage := `'src extensions' is a tool that manages extensions in the extension registry on a Sourcegraph instance.

EXPERIMENTAL: Extensions are experimental functionality on Sourcegraph and in the 'src' tool.
DEPRECATED: We're in the process of removing Sourcegraph extensions with our September release.
Learn more: https://docs.sourcegraph.com/extensions/deprecation
Copy link
Contributor Author

@philipp-spiess philipp-spiess Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @jjinnii @muratsu @ryankscott

Copy link
Member

@eseliger eseliger Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want this to go out in a 3.43.x version?

Copy link
Contributor Author

@philipp-spiess philipp-spiess Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do, since we are also shipping this already on sourcegraph.com but this is a questions for the above people to answer 🙈

Copy link
Member

@eseliger eseliger Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, just let me know when you have a decision, since I already cut 3.43.0 for the branch cut this evening, but can cut 3.43.1 right after merge.

Copy link
Contributor Author

@philipp-spiess philipp-spiess Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. I don't think it's super urgent to get this out with 3.43 (the more important messaging is going out on the web app anyway), so I don't think we need to cut a minor release for that 🙂


Usage:

Expand Down
6 changes: 6 additions & 0 deletions cmd/src/extensions_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ Examples:
nodes {
...RegistryExtensionFields
}
error
}
}
}` + registryExtensionFragment
Expand All @@ -71,6 +72,7 @@ Examples:
ExtensionRegistry struct {
Extensions struct {
Nodes []Extension
Error string
}
}
}
Expand All @@ -81,6 +83,10 @@ Examples:
return err
}

if result.ExtensionRegistry.Extensions.Error != "" {
return fmt.Errorf("%s", result.ExtensionRegistry.Extensions.Error)
}

for _, extension := range result.ExtensionRegistry.Extensions.Nodes {
if err := execTemplate(tmpl, extension); err != nil {
return err
Expand Down