permissions-center: use new permissionSyncJobs query.
#942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test plan: `src snapshot test` runs successfully and fetches perms sync information from a local sg instance.
0xnmn
reviewed
Feb 21, 2023
internal/instancehealth/checks.go
Outdated
| syncCount += 1 | ||
| if sync.Status == "ERROR" { | ||
| syncErrors = append(syncErrors, sync.Message) | ||
| if sync.State == "ERROR" { |
There was a problem hiding this comment.
sync.State == "ERROR" || sync.State == "FAILURE"
Contributor
Author
There was a problem hiding this comment.
it was not the part of original logic, but I agree.
@bobheadxi ping, just in case :)
Member
There was a problem hiding this comment.
+1, the FAILURE state is new IIRC so let's include it :)
0xnmn
reviewed
Feb 21, 2023
internal/instancehealth/checks.go
Outdated
| } | ||
| // Just track one message per state for reference | ||
| seenProviders[key][p.Status] = p.Message | ||
| out.WriteLine(output.Linef(output.EmojiInfo, output.StyleBold, "%s %s %s %s", p.ProviderID, p.ProviderType, p.Message, p.Status)) |
Contributor
Author
There was a problem hiding this comment.
whoops, leftover debug stuff, thanks for catching!
0xnmn
approved these changes
Feb 21, 2023
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
Test plan: `src snapshot test` runs successfully and fetches perms sync information from a local sg instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan:
src snapshot testruns successfully and fetches perms sync information from a local sg instance.Follow-up to https://github.com/sourcegraph/sourcegraph/pull/47933