Closed
Conversation
jeffbyrnes
added
Bug
Merged
jeffbyrnes
force-pushed
the
fix-mismatched-property-name
branch
from
706c8c9 to
fe88c7d
Compare
axelrtgs
previously approved these changes
Jun 29, 2021
axelrtgs
left a comment
axelrtgs
left a comment
There was a problem hiding this comment.
Change looks ok to me.
You might need to add the workflow for the tests to run so the check pass though.
This was referenced Jun 29, 2021
Merged
jeffbyrnes
force-pushed
the
fix-mismatched-property-name
branch
from
fe88c7d to
701942a
Compare
Contributor
|
not sure if I am seeing this wrong but I only see a changelog entry and not the change to the template? |
Presumably it's due to this:
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
h/t to @Fuuzetsu
Introduced in 22520e9
Merged via #30
Fixes #41