Skip to content

Refactor resource#44

Merged
ramereth merged 7 commits intomainfrom
refactor-resource
Jun 30, 2021
Merged

Refactor resource#44
ramereth merged 7 commits intomainfrom
refactor-resource

Conversation

@jeffbyrnes
Copy link
Copy Markdown
Contributor

@jeffbyrnes jeffbyrnes commented Jun 29, 2021 •
edited
Loading

Description

  • Updates test harnesses to use GitHub Actions, so we can satisfy the Sous Chefs’s checks
  • Refactors into a Chef 12-style Custom Resource
  • Various other nits

Issues Resolved

Fixes #41

Check List

  • All tests pass. See TESTING.md for details.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@jeffbyrnes jeffbyrnes added Priority: High Critical work that must be completed Release: Major Release to Chef Supermarket as a major change when merged Tech Debt Will improve the maintainability of the codebase size/large labels Jun 29, 2021
@jeffbyrnes jeffbyrnes requested a review from a team June 29, 2021 20:03
@jeffbyrnes jeffbyrnes self-assigned this Jun 29, 2021
@kitchen-porter
Copy link
Copy Markdown
Contributor

kitchen-porter commented Jun 29, 2021

1 Warning
⚠️ This is a big Pull Request.

Generated by 🚫 Danger

axelrtgs
axelrtgs reviewed Jun 29, 2021
View reviewed changes
Copy link
Copy Markdown

@axelrtgs axelrtgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me,

Just some markdown left to fix and to confirm the tests pass now that they are fixed :)

ping me when you need approval after the tests are passing

@jeffbyrnes
Remove duplicate header in CHANGELOG
d158ade 
v1.0.2 hasn’t been released, and also has two CHANGELOG entries
@jeffbyrnes
Ignore annoying markdown lint rules
ed2c023
@jeffbyrnes
Copy link
Copy Markdown
Contributor Author

jeffbyrnes commented Jun 29, 2021

@axelrtgs looks good now, though a status is hung, I think? This will unblock #43 as well (I’ll rebase that after this merges, and give you a ping when it’s ready again).

@jeffbyrnes jeffbyrnes mentioned this pull request Jun 29, 2021
Open
@jeffbyrnes
Copy link
Copy Markdown
Contributor Author

jeffbyrnes commented Jun 29, 2021

Hmm; how do we bypass or satisfy the “integration” check?

@tas50 @ramereth perhaps y’all can shed some light?

@xorima
Copy link
Copy Markdown
Contributor

xorima commented Jun 30, 2021

Hmm; how do we bypass or satisfy the “integration” check?

@tas50 @ramereth perhaps y’all can shed some light?

Looks like something I thought would work isn't working :( basically it was meant to group all the ci/integration (OS, Suite) checks into 1 required check, I'll get this fixed today.

@xorima xorima mentioned this pull request Jun 30, 2021
Merged
3 tasks
@ramereth ramereth merged commit 78fa06c into main Jun 30, 2021
@ramereth ramereth deleted the refactor-resource branch June 30, 2021 16:01
@kitchen-porter
Copy link
Copy Markdown
Contributor

kitchen-porter commented Jun 30, 2021

Released as: 2.0.0

@jeffbyrnes jeffbyrnes mentioned this pull request Jul 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@axelrtgs axelrtgs axelrtgs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jeffbyrnes jeffbyrnes

Labels

Priority: High Critical work that must be completed Release: Major Release to Chef Supermarket as a major change when merged Tech Debt Will improve the maintainability of the codebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The interface type/method can't be set

5 participants

@jeffbyrnes @kitchen-porter @xorima @axelrtgs @ramereth