Conversation
|
The way I understand prebid timeout: Prebid.js has a default timeout of 3000ms with a buffer of 400ms. So if a publisher does not explicitly set the timeout in the config Can we please check this, and also add a test asserting that a default tmax is passed even when the publisher does not set a timeout |
bharris-sovrn
left a comment
There was a problem hiding this comment.
We should add merge protections to this repo.
According to this page: https://docs.prebid.org/features/timeouts.html you are talking about Auction Timeout (Default 3000MS) and Timeout Buffer (Default 400MS). Shouldn't we be taking into consideration Prebid Server s2sConfig Timeout ? |
|
Irakli and I looked into the timeout buffer and it turns out that it gets added to the timeout. So everything is good to go |
|
Not merging because similar PR is on original Prebid.js repo |
|
Merged into the original Prebid.js repo and synced back to master |
… time, support region, bugfixes (prebid#14374) * AGT-734: Support region for prebid modules (merge 0_3_4 with master) * AGT-730: move spd to partnerData (merge 0_3_4 to master) * AGT-765: Send ad size and pos in impression reporting module (#58) * AGT-765: pos and size * AGT-765: Tests for position resolving * AGT-765: Test fix * AGT-756: Missed vrref in payload fix (#56) * AGT-756: vrref in payload fix * remove comment * AGT-756: Fix vrref bug * AGT-756: Remove comments * AGT-756: Test for vrref * update requestRtt to show more clear time (#59) * AGT-739: Change time to call server (#57) * fix typo, remove parameter duplication (#60) * fix typo, remove parameter duplication * update doc examples * AGT-721: Documentation for region, size, pos (#61) * fix region parameter in table (#62) * update tests * remove unused test --------- Co-authored-by: dmytro-po <dmytro.po@intentiq.com>
No description provided.