Skip to content

Update Sovrn bid adapter to send tmax#61

Closed
ikagotso wants to merge 1 commit intomasterfrom
EX-4749_add_tmax_support
Closed

Update Sovrn bid adapter to send tmax#61
ikagotso wants to merge 1 commit intomasterfrom
EX-4749_add_tmax_support

Conversation

@ikagotso
Copy link

@ikagotso ikagotso commented Jun 6, 2023

No description provided.

@smounitz
Copy link

smounitz commented Jun 7, 2023

The way I understand prebid timeout:

Prebid.js has a default timeout of 3000ms with a buffer of 400ms. So if a publisher does not explicitly set the timeout in the config pbjs.setConfig({ bidderTimeout: 3000})) the bidders will have 2600ms to respond.

Can we please check this, and also add a test asserting that a default tmax is passed even when the publisher does not set a timeout

Copy link

@bharris-sovrn bharris-sovrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add merge protections to this repo.

@ikagotso
Copy link
Author

ikagotso commented Jun 7, 2023

The way I understand prebid timeout:

Prebid.js has a default timeout of 3000ms with a buffer of 400ms. So if a publisher does not explicitly set the timeout in the config pbjs.setConfig({ bidderTimeout: 3000})) the bidders will have 2600ms to respond.

Can we please check this, and also add a test asserting that a default tmax is passed even when the publisher does not set a timeout

According to this page: https://docs.prebid.org/features/timeouts.html

you are talking about Auction Timeout (Default 3000MS) and Timeout Buffer (Default 400MS).

Shouldn't we be taking into consideration Prebid Server s2sConfig Timeout ?

@smounitz
Copy link

smounitz commented Jun 7, 2023

Irakli and I looked into the timeout buffer and it turns out that it gets added to the timeout.
We also tested that if the publisher doesn't set a timeout the default of 3000ms is passed.

So everything is good to go

@ikagotso
Copy link
Author

ikagotso commented Jun 7, 2023

Not merging because similar PR is on original Prebid.js repo

@dmitrybor
Copy link

Merged into the original Prebid.js repo and synced back to master

@dmitrybor dmitrybor closed this Jul 5, 2023
ikagotso pushed a commit that referenced this pull request Feb 4, 2026
… time, support region, bugfixes (prebid#14374)

* AGT-734: Support region for prebid modules (merge 0_3_4 with master)

* AGT-730: move spd to partnerData (merge 0_3_4 to master)

* AGT-765: Send ad size and pos in impression reporting module (#58)

* AGT-765: pos and size

* AGT-765: Tests for position resolving

* AGT-765: Test fix

* AGT-756: Missed vrref in payload fix (#56)

* AGT-756: vrref in payload fix

* remove comment

* AGT-756: Fix vrref bug

* AGT-756: Remove comments

* AGT-756: Test for vrref

* update requestRtt to show more clear time (#59)

* AGT-739: Change time to call server (#57)

* fix typo, remove parameter duplication (#60)

* fix typo, remove parameter duplication

* update doc examples

* AGT-721: Documentation for region, size, pos (#61)

* fix region parameter in table (#62)

* update tests

* remove unused test

---------

Co-authored-by: dmytro-po <dmytro.po@intentiq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments