Open
Conversation
Squashed commits: [2aa500b] Try a different way of creating the proxy [c92d2df] try only one path [2f81ff3] dMatrix Handle null check and more statments [2e6df6f] exit on entering ifs [688fc73] More null checks [3e37688] change error logging [710dae5] missing semicolon [489c337] Put checks back in, change check in c_api [ad5972d] time to break the cpu predictor [7dfa3c0] No more check, do it live [abd64ff] dereference for logging [eb4cd9a] See if we can log what the type for proxy is [74c4376] maybe log something [a367ca2] uncomment for test, pass dMatrix through Booster.java [3e98f14] comment out for testing [66f0d8c] Changes to tests [737b293] some more changes to test [b3796b7] a dMatrix for testing [e995228] Convert long to handle [66ca8c3] c h e c k s t y l e [14f2243] Checkstyle failure [163bfca] missing comma [c869a14] First try at getting dMatrix logic into changes
Squashed commits: [99b8f1f] Remove pom change [7b80fef] Remove changes from cpu_predictor, fix rebase miss [a531053] Cleaning up XGBoosterInplacePredict Further de-newification More clean-up [de6e109] pom change git didn't pick up (+5 squashed commits) Squashed commits: [6182244] One missed pom [ab5bc5e] Update all the poms, even the unused ones [a96c3b9] More clean-up [aea9cd3] Further de-newification [1539100] Cleaning up XGBoosterInplacePredict [a81361d] increment our version (+15 squashed commits) Squashed commits: [c4d6d52] missed param [b343f89] Remove redundant line [5609102] Remove need to pass DMatrix [e31c53d] another missed logging message [f6a2508] comment out some logging [148e29e] undo static cast [6372805] More logging [a173763] change how proxy is cast in cpu predictor [5a08ff8] proxy to stuff [823c92f] Dense adapter changes [9a3214b] change some variables and things [d9dd5c4] uncomment stuff, more logging [7968bca] Set dense data [9e79c2e] Try some stuff with DMatrix [2b8cca6] Print result of p_m.get()
…lc#9192) Bumps [maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) from 3.2.2 to 3.3.0. - [Commits](apache/maven-checkstyle-plugin@maven-checkstyle-plugin-3.2.2...maven-checkstyle-plugin-3.3.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-checkstyle-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Bumps [maven-source-plugin](https://github.com/apache/maven-source-plugin) from 3.2.1 to 3.3.0. - [Commits](apache/maven-source-plugin@maven-source-plugin-3.2.1...maven-source-plugin-3.3.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-source-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#9163) Bumps [maven-assembly-plugin](https://github.com/apache/maven-assembly-plugin) from 3.5.0 to 3.6.0. - [Commits](apache/maven-assembly-plugin@maven-assembly-plugin-3.5.0...maven-assembly-plugin-3.6.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-assembly-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…lc#9158) Bumps rapids-4-spark_2.12 from 23.04.0 to 23.04.1. --- updated-dependencies: - dependency-name: com.nvidia:rapids-4-spark_2.12 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…mlc#9160) Bumps [scalatest_2.12](https://github.com/scalatest/scalatest) from 3.2.15 to 3.2.16. - [Release notes](https://github.com/scalatest/scalatest/releases) - [Commits](scalatest/scalatest@release-3.2.15...release-3.2.16) --- updated-dependencies: - dependency-name: org.scalatest:scalatest_2.12 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [flink-clients](https://github.com/apache/flink) from 1.17.0 to 1.17.1. - [Commits](apache/flink@release-1.17.0...release-1.17.1) --- updated-dependencies: - dependency-name: org.apache.flink:flink-clients dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Thrust implementation of `thrust::all_of/any_of/none_of` adopts an early stopping strategy to bailout early by dividing the input into small batches. This is not ideal for data validation as we expect all data to be valid. The strategy leads to excessive kernel launches and stream synchronization. * Use reduce from dh instead.
* [CI] Update images that are not related to the binary release. - Update clang-tidy, prefer tools from the Ubuntu repository. - Update GPU image to 22.04. - Small cleanup to the tidy script. - Remove gpu_jvm, which seems to be unused.
1. Updated the test logic 2. Added smoke tests for Spark examples. 3. Added integration tests for Spark with Scala 2.13
…es (dmlc#9208) Bumps [scala-collection-compat_2.12](https://github.com/scala/scala-collection-compat) from 2.9.0 to 2.10.0. - [Release notes](https://github.com/scala/scala-collection-compat/releases) - [Commits](scala/scala-collection-compat@v2.9.0...v2.10.0) --- updated-dependencies: - dependency-name: org.scala-lang.modules:scala-collection-compat_2.12 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- remove used variables. - Remove signed comparison warnings.
--------- Co-authored-by: Jiaming Yuan <jm.yuan@outlook.com>
--------- Co-authored-by: Jiaming Yuan <jm.yuan@outlook.com>
Bumps [maven-project-info-reports-plugin](https://github.com/apache/maven-project-info-reports-plugin) from 3.4.3 to 3.4.4. - [Commits](apache/maven-project-info-reports-plugin@maven-project-info-reports-plugin-3.4.3...maven-project-info-reports-plugin-3.4.4) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-project-info-reports-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Use 2.1.0.0 as development version, we will change it to 2.1.0.1 during release.
Bumps `spark.version.gpu` from 3.3.2 to 3.4.1. Updates `spark-core_2.12` from 3.3.2 to 3.4.1 Updates `spark-sql_2.12` from 3.3.2 to 3.4.1 Updates `spark-mllib_2.12` from 3.3.2 to 3.4.1 --- updated-dependencies: - dependency-name: org.apache.spark:spark-core_2.12 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.spark:spark-sql_2.12 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.spark:spark-mllib_2.12 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--------- Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu>
…ges (dmlc#9311) Bumps [scala-collection-compat_2.12](https://github.com/scala/scala-collection-compat) from 2.10.0 to 2.11.0. - [Release notes](https://github.com/scala/scala-collection-compat/releases) - [Commits](scala/scala-collection-compat@v2.10.0...v2.11.0) --- updated-dependencies: - dependency-name: org.scala-lang.modules:scala-collection-compat_2.12 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Jvm inplace predict
- Use the `linalg::Matrix` for storing gradients. - New API for the custom objective. - Custom objective for multi-class/multi-target is now required to return the correct shape. - Custom objective for Python can accept arrays with any strides. (row-major, column-major)
- Remove recover related code. - Clean startup, no need to consider previously connected nodes.
- Add checks in cmake. - Remove mpi related code.
Bumps com.nvidia:rapids-4-spark_2.12 from 23.08.0 to 23.08.1. --- updated-dependencies: - dependency-name: com.nvidia:rapids-4-spark_2.12 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- Enable timeout. - Report connection error from the system. - Handle retry for both tracker connection and peer connection.
…e tests: inplacePredictTest and inplacePredictMultiPredictTest. Extracted common logic of generating random data sets into generateRandomDataSet method. Added new test inplacePredictWithMarginTest which should test the utilization of a margin when performing predictions.
…ounds that we're training on is 10, and we want to use all rounds arbitrarily for this test.
…on_range as iterationRange, so it is clear. Set this iteration range to [0,0) which mimics the calls in inplace_predict methods without margin.
…g the base_score as a parameter for the booster and asserting the values between the predict with margin and predict without margin are similar within a delta(since floating point calculations vary slighty)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.