You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
lightning.json should be updated to reflect current BOLTs
It was generated by a script (structured.py), that @ysangkok wrote and got upstreamed. It worked by processing the output of another script extract-formats.py, which in turn processes the BOLT documents directly. However the BOLTs and the output of extract-formats.py seemingly changed a lot in the meantime and structured.py is now broken and unmaintained.
We should either fix structured.py, or rather, we could use extract-formats.py directly. This script looks to be actively maintained as the BOLTs change, by Rusty.
Note that this is a requirement of implementing TLV support.
btw, ChannelDB.load_data() became significantly slower when we changed to storing raw messages in the db. Most of the time is spent in lnmsg.decode_msg. I believe lnmsg.decode_msg could be made faster, perhaps even as-is, but there is no point now if it will need significant changes anyway.
lightning.jsonshould be updated to reflect current BOLTsstructured.py), that @ysangkok wrote and got upstreamed. It worked by processing the output of another scriptextract-formats.py, which in turn processes the BOLT documents directly. However the BOLTs and the output ofextract-formats.pyseemingly changed a lot in the meantime andstructured.pyis now broken and unmaintained.structured.py, or rather, we could useextract-formats.pydirectly. This script looks to be actively maintained as the BOLTs change, by Rusty.ChannelDB.load_data()became significantly slower when we changed to storing raw messages in the db. Most of the time is spent inlnmsg.decode_msg. I believelnmsg.decode_msgcould be made faster, perhaps even as-is, but there is no point now if it will need significant changes anyway.