lnmsg rewrite, implement TLV, invoice features, varonion, payment secret#6050
Merged
Conversation
SomberNight
force-pushed
the
202003_lnmsg_rewrite
branch
from
7b6a93b to
3ae7b5d
Compare
Will be useful for TLVs where it makes sense to do the conversion in lnmsg, as it might be more complicated than just int.from_bytes().
This implements: - flat feature bits lightning/bolts#666 - feature bit dependencies lightning/bolts#719
this saves around ~13% wall clock time in ChannelDB.load_data
SomberNight
force-pushed
the
202003_lnmsg_rewrite
branch
from
b5bc104 to
eecdd05
Compare
sidhujag
pushed a commit
to syscoin/electrumsys
that referenced
this pull request
Apr 2, 2020
lnmsg rewrite, implement TLV, invoice features, varonion, payment secret
SomberNight
added a commit
that referenced
this pull request
Apr 3, 2020
sidhujag
pushed a commit
to syscoin/electrumsys
that referenced
this pull request
Apr 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes
lightning.json) of the spec but rather can directly use the output of rusty's script from the BOLTs (extract-formats.py)closes #6006