Skip to content

Update to the upcoming WITs#1544

Closed
Mossaka wants to merge 3 commits intospinframework:mainfrom
Mossaka:new-wits
Closed

Update to the upcoming WITs#1544
Mossaka wants to merge 3 commits intospinframework:mainfrom
Mossaka:new-wits

Conversation

@Mossaka
Copy link
Member

@Mossaka Mossaka commented May 26, 2023

Update the WITs to follow the upcoming package format. This will not be able to land until bytecodealliance/wit-bindgen#580 and bytecodealliance/wasmtime#6390 land and possible a new version for wit-bindgen and wasmtime.

I used the package name spin:reactor for the entire WIT package. Happy to change it

Mossaka added 2 commits May 25, 2023 17:37
Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
@rylev
Copy link
Collaborator

rylev commented May 26, 2023

I'm not sure what the package name should be. My first impression was fermyon/spin (much like the GitHub repo). Reactor feels much more like a world name rather than a package name.

@Mossaka
Copy link
Member Author

Mossaka commented May 26, 2023

My first impression was fermyon/spin (much like the GitHub repo). Reactor feels much more like a world name rather than a package name.

Sounds good. Changed it to fermyon:spin

@Mossaka
Copy link
Member Author

Mossaka commented Jun 6, 2023

I believe the upcoming June wasmtime-10 release will include the new WIT syntax changes.

@rylev rylev mentioned this pull request Jun 16, 2023
@rylev
Copy link
Collaborator

rylev commented Jun 20, 2023

Going to close this in favor of #1594. Thanks!

@rylev rylev closed this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants