Merged
Conversation
moved few functionalities from Async.js to Utils.js
Updated the test cases to utilise Promise instead of callbacks
vupadhyay
approved these changes
Aug 23, 2022
fantavlik
reviewed
Oct 12, 2022
fantavlik
reviewed
Oct 12, 2022
fantavlik
reviewed
Oct 12, 2022
fantavlik
reviewed
Oct 13, 2022
fantavlik
reviewed
Oct 13, 2022
fantavlik
reviewed
Oct 13, 2022
| return [new Error("Didn't get a Pivot report back from Splunk"), response]; | ||
| } | ||
| }).catch((err) => { | ||
| // TODO: analyze use of response argument and change accordingly |
Contributor
There was a problem hiding this comment.
I wouldn't worry about this too much, this would be a new scenario that we weren't handling previously - omitting the response seems perfectly fine to me
fantavlik
reviewed
Oct 13, 2022
fantavlik
reviewed
Oct 13, 2022
fantavlik
reviewed
Oct 13, 2022
Examples within README file are updated
akaila-splunk
changed the title
fantavlik
approved these changes
Nov 14, 2022
Contributor
fantavlik
left a comment
fantavlik
left a comment
There was a problem hiding this comment.
This is looking great, thanks for addressing all of those comments 🚀
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
response_timeout' parameter which enables user to specify the timeout for a particular API call.