Merged
Conversation
moved few functionalities from Async.js to Utils.js
Updated the test cases to utilise Promise instead of callbacks
removed augment test case
- added acl_update method to update ACL properties of an entity
This reverts commit 271c275.
Examples within README file are updated
Updated minimist library versions
Doc generation update
Callback promises migration
Sync with master
index.js updated to support examples
ACL properties update feature
Added feature to replace the StoragePassword if exists or Create a new one. Added test case for the same
Support for updated SDK examples
|
@ashah-splunk Can we please add a section in the Readme, describing the Promise pattern with a snippet the way we did here: #155. Thanks. |
Contributor
Author
Hi @ncanumalla-splunk , we have updated REAMDE.md file as per the discussion. Please review it and let us know if any other changes are required. |
|
Looks good to me. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v2.0.0
New features and APIs
Minor changes