Skip to content

Conversation

@felix-seifert
Copy link
Contributor

@felix-seifert felix-seifert commented Oct 31, 2023

This PR is meant to upgrade the different GH Actions workflows to use new versions of existing actions and use new functionalities of these actions.

Changes other than formatting:

  • Update actions/checkout to version 4
  • Update actions/setup-java to version 3
  • Use cache for Maven
  • User Amazon Corretto JDK distribution
  • Ignore being triggered by changes in .gitignore and *.md files
  • Remove usage of already archived samuelmeuli/action-maven-publish@v1
  • Perform same action as samuelmeuli/action-maven-publish@v1 by adding necessary release credentials to actions/setup-java@v3 and calling mvn deploy manually

I tested the changed workflow triggered by pull_request locally. Due to the needed secrets for the push workflow, I could not test the releasing properly.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #156 (47a8f8b) into master (4fa26d8) will increase coverage by 0.60%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #156      +/-   ##
============================================
+ Coverage     75.83%   76.44%   +0.60%     
- Complexity      284      286       +2     
============================================
  Files            42       42              
  Lines           985      985              
  Branches         43       43              
============================================
+ Hits            747      753       +6     
+ Misses          212      207       -5     
+ Partials         26       25       -1     

see 1 file with indirect coverage changes

@felix-seifert felix-seifert force-pushed the felixs/update-workflows branch 2 times, most recently from 134fa19 to 431d20e Compare November 1, 2023 09:19
@felix-seifert felix-seifert marked this pull request as ready for review November 1, 2023 09:35
@felix-seifert felix-seifert force-pushed the felixs/update-workflows branch from 431d20e to 8328b76 Compare November 1, 2023 14:49
dennisgranath
dennisgranath previously approved these changes Nov 6, 2023
Copy link
Contributor

@dennisgranath dennisgranath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I guess we notices if release doesn't work after merge...

@felix-seifert felix-seifert merged commit a4399a7 into master Nov 6, 2023
@felix-seifert felix-seifert deleted the felixs/update-workflows branch November 6, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants