Skip to content

Conversation

@felix-seifert
Copy link
Contributor

@felix-seifert felix-seifert commented Nov 1, 2023

This PR builds on top of the two previous PRs #156 and #157. After merging these two PRs, the branch of this PR should be rebased on top of master.

As the involved version upgrades enable the compatibility with newer Java versions, the tests should then succeed in the three different Java versions 11, 17 and 21.

After merging this PR, we can upgrade the version of the library to 0.2.0.

@codecov
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #158 (0874872) into master (45eb58c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #158   +/-   ##
=========================================
  Coverage     76.44%   76.44%           
  Complexity      286      286           
=========================================
  Files            42       42           
  Lines           985      985           
  Branches         43       43           
=========================================
  Hits            753      753           
  Misses          207      207           
  Partials         25       25           

dennisgranath
dennisgranath previously approved these changes Nov 6, 2023
Copy link
Contributor

@dennisgranath dennisgranath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felix-seifert felix-seifert merged commit ec7da9b into master Nov 7, 2023
@felix-seifert felix-seifert deleted the felixs/java-versions branch November 7, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants