Add setMultiTenantConnectionProvider to org.springframework.orm.hibernate5.LocalSessionFactoryBean [SPR-14072]

[spring-projects-issues]

Menachem Rath opened SPR-14072 and commented

#15449 added the methods setMultiTenantConnectionProvider and setCurrentTenantIdentifierResolver methods to LocalSessionFactoryBean in org.springframework.orm.hibernate4

In org.springframework.orm.hibernate5.LocalSessionFactoryBean only the setCurrentTenantIdentifierResolver exists, and it doesn't appear t be working.

Looking at the Hibernate documentation for:

• version 4 - http://docs.jboss.org/hibernate/orm/4.3/devguide/en-US/html_single/#d5e4817
• version 5 - http://docs.jboss.org/hibernate/orm/5.1/userguide/html_single/Hibernate_User_Guide.html#_multitenantconnectionprovider

I don't see a difference in the behavior of multi tenant.

---

Affects: 4.2.5

Reference URL: http://docs.jboss.org/hibernate/orm/5.1/userguide/html_single/Hibernate_User_Guide.html#_multitenantconnectionprovider

Issue Links:

• LocalSessionFactoryBean (hibernate5) does not correctly pass custom ClassLoader to Hibernate [SPR-13879] #18452 LocalSessionFactoryBean (hibernate5) does not correctly pass custom ClassLoader to Hibernate
• Hibernate 4 Multi Tenancy Feature Support [SPR-10823] #15449 Hibernate 4 Multi Tenancy Feature Support
• Hibernate5 metadata access [SPR-13710] #18285 Hibernate5 metadata access
• Workaround for Hibernate bug: setCurrentTenantIdentifierResolver not respected [SPR-14476] #19045 Workaround for Hibernate bug: setCurrentTenantIdentifierResolver not respected

Referenced from: commits 5f64064

[spring-projects-issues]

Juergen Hoeller commented

The reason is simply that, for whatever reason, Hibernate 5 does provide an explicit setCurrentTenantIdentifierResolver method on its Configuration class but not a corresponding setMultiTenantConnectionProvider. I'll see what we can do here, possibly using the properties-based approach along the lines of what we do for Hibernate 4... just for this particular setting.

Juergen

[spring-projects-issues]

Juergen Hoeller commented

I've introduced this for Spring Framework 4.3 now, as a setMultiTenantConnectionProvider method on both LocalSessionFactoryBuilder and LocalSessionFactoryBean. Since those classes have been reworked for 4.3 already, let's consider this feature as 4.3+ as well. After all, it drags a rather involved new Hibernate SPI dependency into those classes which might cause side effects.

Juergen

[spring-projects-issues]

Menachem Rath commented

Many thanks!