[Valet 4.0] Drop support for Xcode 9, Xcode 10, Swift 4.0, and Swift 4.2#190
Merged
dfed merged 7 commits intodevelop--4.0from Dec 24, 2019
Merged
[Valet 4.0] Drop support for Xcode 9, Xcode 10, Swift 4.0, and Swift 4.2#190dfed merged 7 commits intodevelop--4.0from
dfed merged 7 commits intodevelop--4.0from
Conversation
dfed
force-pushed
the
dfed--simplify-ci-v4
branch
from
6b69d8d to
0c34904
Compare
dfed
changed the title
dfed
force-pushed
the
dfed--simplify-ci-v4
branch
from
d4ad9c9 to
2c13a1b
Compare
dfed
changed the title
dfed
force-pushed
the
dfed--simplify-ci-v4
branch
from
2c13a1b to
921aa52
Compare
This was referenced Dec 22, 2019
[Valet 4.0] Adopt Swift 5 syntax, and enable support for SinglePromptSecureEnclaveValet on tvOS
#191
Merged
dfed
changed the title
dfed
force-pushed
the
dfed--simplify-ci-v4
branch
from
921aa52 to
f087d9e
Compare
…ulators for older OSes
…hat require a passcode to be set
dfed
force-pushed
the
dfed--simplify-ci-v4
branch
from
f087d9e to
e9848e0
Compare
dnkoutso
approved these changes
Dec 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting to tackle #179 in bits and pieces. This PR is pointed at
develop--4.0.The commit moves us to Cocoapods 1.8, which enables us to start linting our Podspec using Xcode 11.
The next commit starts linting our Podspec using Xcode 11 in CI.
The next commit drops support for Xcode 9 and 10, by removing Xcode 9 and 10 checks in CI and updating our README. This PR continues to support all currently supported operating systems. However, we do have to drop macOS 10.13 and macOS 10.14 in CI, as Travis CI can't build using Xcode 11 and then run tests on macOS 10.13 and macOS 10.14 – testing on macOS 10.13 requires building with Xcode 9, and testing on macOS 10.14 requires building with Xcode 10.
The next commit drops explicit support for Swift 4.0 and 4.2, consolidating on Swift 5.0. We don't have any changes that break Swift 4.0 or Swift 4.2 yet, but we will.
The next commits get CI running again. This was my first attempt to target older operating systems from a newer Xcode, and there were some bumps 😬.