[Valet 4.0] Attempt to run mac unit tests in a signed host app in CI#195
Closed
dfed wants to merge 8 commits intodfed--simplify-ci-v4from
Closed
[Valet 4.0] Attempt to run mac unit tests in a signed host app in CI#195dfed wants to merge 8 commits intodfed--simplify-ci-v4from
dfed wants to merge 8 commits intodfed--simplify-ci-v4from
Conversation
dfed
commented
Dec 23, 2019
| static let identifier = Identifier(nonEmpty: "valet_testing")! | ||
| let valet = Valet.valet(with: identifier, accessibility: .whenUnlocked) | ||
|
|
||
| // FIXME: Need a different flavor (Synchronizable can't be tested on Mac currently |
Collaborator
Author
There was a problem hiding this comment.
these FIXMEs are invalid if CI passes 😬
dfed
force-pushed
the
dfed--simplify-ci-v4
branch
from
f087d9e to
e9848e0
Compare
dfed
force-pushed
the
dfed--run-signed-tests-on-mac
branch
from
2d78329 to
b2015a0
Compare
dfed
force-pushed
the
dfed--run-signed-tests-on-mac
branch
from
b2015a0 to
fc87fe2
Compare
Collaborator
Author
|
Okay, once again this is a fail.
If we had a paid developer account, I think we could follow these instructions to get things working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'll see if CI passes. I try this every year. But maybe with Xcode 11 it'll finally work. Let's see what CI says.
Built on top of #190.