Conversation
Collaborator
This should be solved by #30 which we plan to merge today, we can rebase this onto it soon! |
baxen
approved these changes
Sep 9, 2024
Collaborator
baxen
left a comment
baxen
left a comment
There was a problem hiding this comment.
LGTM! Tested with my own setup and can reproduces this fixes the integration. Let's merge after we can rebase onto the generate changes
andrewblane
force-pushed
the
alane/fix_bedrock
branch
from
3f0cee8 to
bd34422
Compare
This makes the moderators compatible with providers which don't support empty message lists
andrewblane
force-pushed
the
alane/fix_bedrock
branch
from
bd34422 to
74c821b
Compare
lifeizhou-ap
added a commit
that referenced
this pull request
Sep 18, 2024
* main: feat: Rework error handling (#48) chore(release): release version 0.9.0 (#45) chore: add just command for releases and update pyproject for changelog (#43) feat: convert ollama provider to an openai configuration (#34) fix: Bedrock Provider request (#29) test: Update truncate and summarize tests to check for sytem prompt t… (#42) chore: update test_tools to read a file instead of get a password (#38) fix: Use placeholder message to check tokens (#41) feat: rewind to user message (#30) chore: Update LICENSE (#40) fix: shouldn't hardcode truncate to gpt4o mini (#35)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Bedrock provider
- Temporarily comments outmoderator.rewritecall ingenerateto get Bedrock to function; need to validate that this breaks becauserewritebreaks when no messages returned and handle correctlyOpen questions:exchange, assuming that it's redundant with the new retry decorator in the Provider. Do we have any reason to keep the retries ingenerate?