Merged
Conversation
Collaborator
lukealvoeiro
commented
Sep 6, 2024
lukealvoeiro
commented
- Removes retry logic from Exchange.generate, as this may result in undefined behavior
- Adds a rewind_to_last_user_message method on the Exchange
baxen
approved these changes
Sep 6, 2024
src/exchange/exchange.py
Outdated
| except HTTPStatusError as e: | ||
| # in the future, if models are hosted on machines we may need to add | ||
| # other types of exceptions here | ||
| raise FailedToGenerateMessageError(f"Failed to generate message: {e}") from e |
Collaborator
There was a problem hiding this comment.
I'd suggest leaving this as the original HTTP Status Error? that has more actionable information when caught downstream or for debugging (like the request etc)
Collaborator
Author
There was a problem hiding this comment.
Ok, I figured we might want to handle all generate errors similarly, but not attached to it.
src/exchange/exchange.py
Outdated
| ) | ||
| self.checkpoint_data.message_index_offset = new_index | ||
|
|
||
| def rewind_to_last_user_message(self) -> None: |
Collaborator
There was a problem hiding this comment.
nit: rewind_to sounds like the last user message is included, maybe rewind_past_
Collaborator
Author
There was a problem hiding this comment.
👍🏼. Thinking about it a bit more, there is no other situation that you would rewind to. Thoughts on just calling it rewind?
| ex.rewind_to_last_user_message() | ||
|
|
||
| assert len(ex.messages) == 2 | ||
| assert len(ex.checkpoint_data.checkpoints) == 2 |
Collaborator
There was a problem hiding this comment.
probably worth also adding tool use/results into this test?
lukealvoeiro
changed the title
andrewblane
approved these changes
Sep 9, 2024
lifeizhou-ap
added a commit
that referenced
this pull request
Sep 18, 2024
* main: feat: Rework error handling (#48) chore(release): release version 0.9.0 (#45) chore: add just command for releases and update pyproject for changelog (#43) feat: convert ollama provider to an openai configuration (#34) fix: Bedrock Provider request (#29) test: Update truncate and summarize tests to check for sytem prompt t… (#42) chore: update test_tools to read a file instead of get a password (#38) fix: Use placeholder message to check tokens (#41) feat: rewind to user message (#30) chore: Update LICENSE (#40) fix: shouldn't hardcode truncate to gpt4o mini (#35)
codefromthecrypt
pushed a commit
to codefromthecrypt/exchange
that referenced
this pull request
Oct 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.