Apply buildFromSdist *after* settings overlay#252
Closed
srid wants to merge 2 commits intothebug-reprofrom
Closed
Conversation
Owner
Author
|
This breaks emanote, |
Owner
Author
|
@roberth I'm gonna timebox the debugging/fix for this. If I can't find anything that works in time, I'm gonna just make |
Owner
Author
|
Closing in favour of #253 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildFromSdistappears to behave oddly so as to invalid user's settings (jailbreak,check, etc.) from the next overlay.The solution is to create a 3rd overlay, dedicated to applying
buildFromSdistand add this overlay after packages and settings overlay.Resolves #238 ... in particular, I can build @johnhampton's repo. PR is against #251 (which contains the bug repro) for easier review.