Make buildFromSdist configurable; turn it off by default#253
Merged
Conversation
Merged
This was referenced Feb 29, 2024
Closed
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #238 (PR on top of #251 which contains bug repro)
settings.<name>.buildFromSdistis now a configurable option, rather than hardcoded defaultfalse, because it causes problems with other settingsjailbreakandchecksetting:settingsoverride not being applied whensourceis overriden #238removeReferencesTobehaviour: ApplybuildFromSdist*after* settings overlay #252 (comment)