buildFromSdist: deal with breakage of removeReferencesTo#287
Merged
Conversation
Incidentally, `buildFromSdist` hasn't been changed since 2018: NixOS/nixpkgs#48699
srid
force-pushed
the
buildFromSdist-removeReferencesTo
branch
from
295c1d3 to
01fb3da
Compare
Also add a warning about potential issues. The function hasn't been updated upstream since 2018 - NixOS/nixpkgs#48699
srid
added a commit
to srid/emanote
that referenced
this pull request
Mar 29, 2024
srid
added a commit
that referenced
this pull request
Apr 15, 2026
Use drvAttrs.disallowedReferences presence check instead of grepping the binary. This directly tests the PR #287 regression: if buildFromSdist (overrideCabal) runs after removeReferencesTo (overrideAttrs), it creates a new derivation that loses disallowedReferences. The current ordering (removeReferencesTo after buildFromSdist) preserves it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildFromSdistis fucked up for yet another reason. It breaksremoveReferencesTo:haskell-flake/nix/modules/project/settings/all.nix
Lines 340 to 347 in 4aab279
The solution here is to apply
removeReferencesToafterbuildFromSdist.