Skip to content
This repository was archived by the owner on Apr 28, 2021. It is now read-only.

Add CMake#5

Closed
otreblan wants to merge 6 commits intoss7m:masterfrom
otreblan:master
Closed

Add CMake#5
otreblan wants to merge 6 commits intoss7m:masterfrom
otreblan:master

Conversation

@otreblan
Copy link

The Makefile was removed

@otreblan
Copy link
Author

Also added to the aur, but until this is merged it will use my fork because CMake.

@ss7m
Copy link
Owner

ss7m commented Apr 22, 2020

I'm not an experienced C programmer- what advantage does cmake have over regular make, especially for a project as small as this?

@otreblan
Copy link
Author

CMake is a build system generator. It can be used for more than making Makefiles.
https://stackoverflow.com/questions/25789644/difference-between-using-makefile-and-cmake-to-compile-the-code

@ss7m
Copy link
Owner

ss7m commented Apr 22, 2020

Would you mind also updating the README to reflect the changed installation process?

@otreblan
Copy link
Author

ok

@ss7m
Copy link
Owner

ss7m commented Apr 22, 2020

I appreciate your taking interest in my project, but I'm still not convinced there's much to gain from using CMake, versus what I perceive to be the added complexity. Considering that the source code consists of 1 file, and that this change will make it harder for me to maintain this in the future, I don't think I'm going to merge this at this time.

@Titaniumtown
Copy link

can this pull request be re-opened?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments