Skip to content

[WIP] Image Support#33

Closed
gregziegan wants to merge 5 commits intosstur:masterfrom
gregziegan:thebritican/image-support
Closed

[WIP] Image Support#33
gregziegan wants to merge 5 commits intosstur:masterfrom
gregziegan:thebritican/image-support

Conversation

@gregziegan
Copy link
Copy Markdown

@gregziegan gregziegan commented Apr 10, 2016

Work-in-progress fix for #6

Do not merge: The following PRs need to be merged first.

GIF progress:

We can use this branch as a base to get the rest of these tasks done, or create small PRs for each and link them here in this description.

  • Render based on Entity & Decorator
  • Resizing
  • Movement with ImageSpan selection
  • Drag And Drop
  • Export
  • Import via URL (exact copy of Link Button)
  • Copy / Paste
  • Properly show selection
  • Loading UI
  • Hooks for uploads
  • Attachments

@gregziegan
Copy link
Copy Markdown
Author

@sstur so i wrote my own getBlocksInSelection function. andddd just discovered that it's in draft-js-utils. If you'd like to compare the styles/benchmark that'd be great! I don't really care which implementation we use.

@frenkelor
Copy link
Copy Markdown

Hey @sstur , @thebritican I can help you finish this.
Please let me know if you need help .

@gregziegan
Copy link
Copy Markdown
Author

Feel free to keep up the work on this branch! I mentioned in the corresponding issue some of the blockers with faking selection. Curious what you have in mind for a solution!

@frenkelor
Copy link
Copy Markdown

Can you commit to your latest code ?

@gregziegan gregziegan mentioned this pull request May 2, 2016
@oeddyo
Copy link
Copy Markdown

oeddyo commented Jun 13, 2016

Desperately needing this!!! THanks guys

@ZeroCho
Copy link
Copy Markdown
Contributor

ZeroCho commented Jun 14, 2016

Me, too! Any recent news?

@sstur
Copy link
Copy Markdown
Owner

sstur commented Jun 15, 2016

Sorry for the delay. I'll get back on this as soon as I can find some time. I appreciate you using this editor. I want to keep making it more awesome!

@magestican
Copy link
Copy Markdown

Any news on this pull request? I would greatly appreciate it !

@lidrissi
Copy link
Copy Markdown

any news please ?

@bherila
Copy link
Copy Markdown
Collaborator

bherila commented Jul 14, 2017

If someone wants to work on this, I can merge it to a branch that can be used for further development. Please let me know.

@bherila
Copy link
Copy Markdown
Collaborator

bherila commented Jul 14, 2017

Closing in favor of #40, please let me know if this should be reopened.

@bherila bherila closed this Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants