Conversation
sstur
force-pushed
the
image-support
branch
4 times, most recently
from
5ca959a to
1a176c9
Compare
|
Perhaps inline images without a selected background is still good enough for some editors? Could this feature be shipped with some resizing logic and paste / drag features? Looking at draft-js-plugins/draft-js-plugins#243 there's a lot of code that can be adapted for resizing and drag and drop. I can try to update this PR with similar code at the end of the week |
|
What's the state of this PR? Will it get merged soon? |
|
@jason-uh I made a package react-rte-image which forks this package's image-support branch. You can use it temporarily until this package supports image. |
|
Thanks, @ZeroCho. I'll check it out. |
|
Any plan to merge this anytime soon? :) |
|
@alfonsoperez @jason-uh @ZeroCho Could you fix the merge conflict and then I can do a final review pass and merge. Sorry for the delay. Thanks, |
|
@bherila Did you mean react-rte-image? or Do you want me to make a PR on this? Edit: I fixed conflict in react-rte-image. Want me to make a PR here? |
|
Maybe create a PR to pull react-rte-image back to master? I think it would be really nice to bring the forks back in sync with each other, so that as we merge the other community contributions everyone can benefit 😄 |
|
Okay I'll do it today |
|
@ZeroCho thanks, can you advise what the right way to merge this would be? Looks like there is still some conflict Thanks, |
* should work when the micro-dependencies update * oh ya there was a toolbar button * make things work except resizer * use ENTITY_TYPE.IMAGE * fix some lint and flow errors * modify image style (#42) * ImageSpan: add autobind * remove resizing logic * remove selected class and use built-in selection * ImageSpan should have overflow hidden to prevent selection background from overflowing * fix warning about font size * demo * readme * ssr test * Update webpack.config.js * 0.5.1 * 0.5.2 ssr test * react-rte-image 0.6.0 * No tilde && ImageButton as an option * for CI and eslint * 0.9.1 readme update for toolbar configuration * 0.11.1 restore dist folder * Revert README.md * Remove dist and lib folder * Remove dist and lib folder(again) * Revert package.json * Fix for flow
* should work when the micro-dependencies update * oh ya there was a toolbar button * make things work except resizer * use ENTITY_TYPE.IMAGE * fix some lint and flow errors * modify image style (#42) * ImageSpan: add autobind * remove resizing logic * remove selected class and use built-in selection * ImageSpan should have overflow hidden to prevent selection background from overflowing * fix warning about font size * demo * readme * ssr test * Update webpack.config.js * 0.5.1 * 0.5.2 ssr test * react-rte-image 0.6.0 * No tilde && ImageButton as an option * for CI and eslint * 0.9.1 readme update for toolbar configuration * 0.11.1 restore dist folder * Revert README.md * Remove dist and lib folder * Remove dist and lib folder(again) * Revert package.json * Fix for flow
* should work when the micro-dependencies update * oh ya there was a toolbar button * make things work except resizer * use ENTITY_TYPE.IMAGE * fix some lint and flow errors * modify image style (#42) * ImageSpan: add autobind * remove resizing logic * remove selected class and use built-in selection * ImageSpan should have overflow hidden to prevent selection background from overflowing * fix warning about font size * demo * readme * ssr test * Update webpack.config.js * 0.5.1 * 0.5.2 ssr test * react-rte-image 0.6.0 * No tilde && ImageButton as an option * for CI and eslint * 0.9.1 readme update for toolbar configuration * 0.11.1 restore dist folder * Revert README.md * Remove dist and lib folder * Remove dist and lib folder(again) * Revert package.json * Fix for flow
6 participants
I'm making this a PR to facilitate some discussion around @thebritican's approach (this is mostly his code at this point).