Skip to content

Use the upstream version of the external secrets operator for dev/ci#2405

Closed
kovayur wants to merge 1 commit intomainfrom
yury/eso-upstream
Closed

Use the upstream version of the external secrets operator for dev/ci#2405
kovayur wants to merge 1 commit intomainfrom
yury/eso-upstream

Conversation

@kovayur
Copy link
Copy Markdown
Contributor

@kovayur kovayur commented Jul 24, 2025

Description

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources
  • (If applicable) Changes to the dp-terraform Helm values have been reflected in the addon on integration environment

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@kovayur kovayur requested a review from kurlov July 24, 2025 12:58
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jul 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur, kurlov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur
Copy link
Copy Markdown
Contributor Author

kovayur commented Aug 4, 2025

/retest

1 similar comment
@kovayur
Copy link
Copy Markdown
Contributor Author

kovayur commented Sep 1, 2025

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Sep 1, 2025

@kovayur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e b5ef249 link true /test e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kovayur kovayur closed this Sep 1, 2025
@kovayur
Copy link
Copy Markdown
Contributor Author

kovayur commented Sep 1, 2025

superseded by #2417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants