ROX-12886: improve public API error messages for better UX#2417
Merged
johannes94 merged 4 commits intomainfrom Sep 1, 2025
Merged
ROX-12886: improve public API error messages for better UX#2417johannes94 merged 4 commits intomainfrom
johannes94 merged 4 commits intomainfrom
Conversation
Contributor
Author
|
/retest |
johannes94
changed the title
This change improves error handling across public API endpoints to provide more user-friendly error messages that UIs can display directly to users. Key improvements: - Replace regex patterns in central name validation with human-readable text - Improve cloud provider/region validation error messages with clearer formatting - Enhance search parameter validation messages Before: "name does not match ^[a-z]([-a-z0-9]*[a-z0-9])?$" After: "name must use lowercase letters, numbers, and hyphens only (max 32 characters)" 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Update test assertions to match the new user-friendly error messages: - Region validation error message format - Instance type validation error message format 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
johannes94
force-pushed
the
jmalsam/improve-public-api-errors
branch
from
edf0ed9 to
350a17c
Compare
kurlov
approved these changes
Aug 28, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, kurlov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Contributor
|
New changes are detected. LGTM label has been removed. |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest Appears to be a flake with FS not recognizing the new GitopsConfig. |
johannes94
force-pushed
the
jmalsam/improve-public-api-errors
branch
from
a344141 to
775bd40
Compare
johannes94
temporarily deployed
to
development
GitHub Actions
Inactive
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves error handling across public API endpoints to provide more user-friendly error messages that UIs can display directly to users.
Key improvements:
Before: "name does not match ^a-z?$"
After: "name must use lowercase letters, numbers, and hyphens only (max 32 characters)"
This ensures UI teams can display error messages directly without additional processing or translation.