chore: refactor e2e tests to not rely on stackrox/stackrox repo#146
Merged
chore: refactor e2e tests to not rely on stackrox/stackrox repo#146
Conversation
dhaus67
force-pushed
the
dh/refactor-e2e
branch
from
2739bfe to
fe87bc7
Compare
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dhaus67
force-pushed
the
dh/refactor-e2e
branch
3 times, most recently
from
1dfaaa1 to
443c1e6
Compare
stehessel
approved these changes
Apr 25, 2024
dhaus67
force-pushed
the
dh/refactor-e2e
branch
from
443c1e6 to
25e514f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor the existing E2E tests to not rely on the stackrox repository as well as not require the GCP credentials.
Instead rely on the stackrox/actions with our infra to create a demo cluster. While this now leads to an increase in the E2E test pipeline duration (25mins instead of 15mins) it does streamline things quite a bit and is in my opinion worthwhile removing those other dependencies.
Also as another small QoL improvement switched to downloading roxctl from central.
Note that unfortunately, at the current time, we don't offer to just create a "plain" central installation in infra with custom images and only the "qa-demo" instances offer overriding the image.
Successful run: https://github.com/stackrox/central-login/actions/runs/8836477079/job/24263130190?pr=146